From: Jens Axboe <axboe@kernel.dk>
To: Max Gurtovoy <mgurtovoy@nvidia.com>,
stefanha@redhat.com, virtualization@lists.linux.dev,
mst@redhat.com
Cc: kvm@vger.kernel.org, linux-block@vger.kernel.org, oren@nvidia.com
Subject: Re: [PATCH v2] virtio_blk: implement init_hctx MQ operation
Date: Thu, 8 Aug 2024 07:37:19 -0600 [thread overview]
Message-ID: <35c7b39f-415d-4d23-bf44-75e655f3eb8a@kernel.dk> (raw)
In-Reply-To: <20240807224129.34237-1-mgurtovoy@nvidia.com>
On 8/7/24 4:41 PM, Max Gurtovoy wrote:
> Set the driver data of the hardware context (hctx) to point directly to
> the virtio block queue. This cleanup improves code readability and
> reduces the number of dereferences in the fast path.
Looks good, and that is the idiomatic way to do this.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2024-08-08 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240912064617eucas1p1c3191629f76e04111d4b39b15fea350a@eucas1p1.samsung.com>
2024-08-07 22:41 ` [PATCH v2] virtio_blk: implement init_hctx MQ operation Max Gurtovoy
2024-08-08 6:53 ` John Garry
2024-08-08 13:37 ` Jens Axboe [this message]
2024-08-12 11:15 ` Christoph Hellwig
2024-09-12 6:46 ` Marek Szyprowski
2024-09-12 6:57 ` Michael S. Tsirkin
2024-09-16 22:06 ` Max Gurtovoy
2024-09-17 14:09 ` Marek Szyprowski
2024-09-22 22:47 ` Max Gurtovoy
2024-09-24 8:06 ` Francesco Lavra
2024-09-24 8:11 ` Max Gurtovoy
2024-09-24 10:26 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c7b39f-415d-4d23-bf44-75e655f3eb8a@kernel.dk \
--to=axboe@kernel.dk \
--cc=kvm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=oren@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).