Re: [PATCH V2 2/8] vhost: flush dev once during vhost_dev_stop

From: Jason Wang <jasowang@redhat.com>
To: Mike Christie <michael.christie@oracle.com>,
	stefanha@redhat.com, mst@redhat.com, sgarzare@redhat.com,
	virtualization@lists.linux-foundation.org, arbn@yandex-team.com
Subject: Re: [PATCH V2 2/8] vhost: flush dev once during vhost_dev_stop
Date: Tue, 17 May 2022 11:16:22 +0800	[thread overview]
Message-ID: <3d4600f1-b34d-ffad-256b-65cba1c9c380@redhat.com> (raw)
In-Reply-To: <20220515202922.174066-3-michael.christie@oracle.com>


在 2022/5/16 04:29, Mike Christie 写道:
> When vhost_work_dev_flush returns all work queued at that time will have
> completed. There is then no need to flush after every vhost_poll_stop
> call, and we can move the flush call to after the loop that stops the
> pollers.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>


Acked-by: Jason Wang <jasowang@redhat.com>


> ---
>   drivers/vhost/vhost.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index 1d84a2818c6f..9f8de04bb673 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -653,11 +653,11 @@ void vhost_dev_stop(struct vhost_dev *dev)
>   	int i;
>   
>   	for (i = 0; i < dev->nvqs; ++i) {
> -		if (dev->vqs[i]->kick && dev->vqs[i]->handle_kick) {
> +		if (dev->vqs[i]->kick && dev->vqs[i]->handle_kick)
>   			vhost_poll_stop(&dev->vqs[i]->poll);
> -			vhost_work_dev_flush(dev->vqs[i]->poll.dev);
> -		}
>   	}
> +
> +	vhost_work_dev_flush(dev);
>   }
>   EXPORT_SYMBOL_GPL(vhost_dev_stop);
>   

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization