From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@suse.de>
Cc: virtualization@lists.osdl.org
Subject: Re: Patch: use .pushsection/.popsection
Date: Tue, 08 Aug 2006 23:33:27 -0700 [thread overview]
Message-ID: <44D981B7.6050704@goop.org> (raw)
In-Reply-To: <200608090826.21157.ak@suse.de>
Andi Kleen wrote:
> I have already merged it.
>
> But in theory all code should run fine in .fixup, so it shouldn't
> actually unbreak anything.
>
No, it makes actual broken code without this:
#define RESTORE_REGS \
RESTORE_INT_REGS; \
1: popl %ds; \
CFI_ADJUST_CFA_OFFSET -4;\
/*CFI_RESTORE ds;*/\
2: popl %es; \
CFI_ADJUST_CFA_OFFSET -4;\
/*CFI_RESTORE es;*/\
.section .fixup,"ax"; \
3: movl $0,(%esp); \
jmp 1b; \
4: movl $0,(%esp); \
jmp 2b; \
.previous; \
...
Those jmp 1b's look a lot like infinite loops if 1: is in the same
section as 3:.
J
prev parent reply other threads:[~2006-08-09 6:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 6:02 Patch: use .pushsection/.popsection Zachary Amsden
2006-08-09 6:09 ` Jeremy Fitzhardinge
2006-08-09 6:26 ` Andi Kleen
2006-08-09 6:33 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D981B7.6050704@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).