From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS address space Date: Fri, 27 Oct 2006 14:31:41 -0700 Message-ID: <45427ABD.6070407@goop.org> References: <1161920325.17807.29.camel@localhost.localdomain> <1161920535.17807.33.camel@localhost.localdomain> <20061027113001.GB8095@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061027113001.GB8095@elf.ucw.cz> Sender: linux-kernel-owner@vger.kernel.org To: Pavel Machek Cc: Rusty Russell , Andrew Morton , virtualization , lkml - Kernel Mailing List List-Id: virtualization@lists.linuxfoundation.org Pavel Machek wrote: > Indentation is b0rken here. > Oops. How strange. > And... is get_user right primitive for accessing area that may not be > there? I'm pretty sure there's precedent for using __get_user in this way (get_user is a different matter, since it cares about whether the address is within the user part of the address space). Certainly in arch/i386 code there shouldn't be a problem. Is there some other way to achieve the same effect (without manually setting up an exception/fixup block)? J