* Is this a typo?
@ 2006-10-30 23:58 Jeremy Fitzhardinge
2006-10-31 0:06 ` Chris Wright
0 siblings, 1 reply; 3+ messages in thread
From: Jeremy Fitzhardinge @ 2006-10-30 23:58 UTC (permalink / raw)
To: Zachary Amsden; +Cc: Chris Wright, Virtualization Mailing List
static pmd_t * __init one_md_table_init(pgd_t *pgd)
{
pud_t *pud;
pmd_t *pmd_table;
#ifdef CONFIG_X86_PAE
pmd_table = (pmd_t *) alloc_bootmem_low_pages(PAGE_SIZE);
paravirt_alloc_pmd(__pa(page_table) >> PAGE_SHIFT);
^^^^^^^^^^ pmd_table?
set_pgd(pgd, __pgd(__pa(pmd_table) | _PAGE_PRESENT));
pud = pud_offset(pgd, 0);
if (pmd_table != pmd_offset(pud, 0))
BUG();
#else
pud = pud_offset(pgd, 0);
pmd_table = pmd_offset(pud, 0);
#endif
return pmd_table;
}
Also, did you anticipate that these paravirt_alloc_* functions would be
useful for Xen to maintain the "pagetable pages must be RO" constraint?
Or do you think that will need to be done in a second pass (which is how
it seems to me).
J
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Is this a typo?
2006-10-30 23:58 Is this a typo? Jeremy Fitzhardinge
@ 2006-10-31 0:06 ` Chris Wright
2006-10-31 0:12 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wright @ 2006-10-31 0:06 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Chris Wright, Virtualization Mailing List
* Jeremy Fitzhardinge (jeremy@goop.org) wrote:
> static pmd_t * __init one_md_table_init(pgd_t *pgd)
> {
> pud_t *pud;
> pmd_t *pmd_table;
>
> #ifdef CONFIG_X86_PAE
> pmd_table = (pmd_t *) alloc_bootmem_low_pages(PAGE_SIZE);
> paravirt_alloc_pmd(__pa(page_table) >> PAGE_SHIFT);
> ^^^^^^^^^^ pmd_table?
Weird, that should be fixed already
thanks,
-chris
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Is this a typo?
2006-10-31 0:06 ` Chris Wright
@ 2006-10-31 0:12 ` Jeremy Fitzhardinge
0 siblings, 0 replies; 3+ messages in thread
From: Jeremy Fitzhardinge @ 2006-10-31 0:12 UTC (permalink / raw)
To: Chris Wright; +Cc: Virtualization Mailing List
Chris Wright wrote:
> * Jeremy Fitzhardinge (jeremy@goop.org) wrote:
>
>> static pmd_t * __init one_md_table_init(pgd_t *pgd)
>> {
>> pud_t *pud;
>> pmd_t *pmd_table;
>>
>> #ifdef CONFIG_X86_PAE
>> pmd_table = (pmd_t *) alloc_bootmem_low_pages(PAGE_SIZE);
>> paravirt_alloc_pmd(__pa(page_table) >> PAGE_SHIFT);
>> ^^^^^^^^^^ pmd_table?
>>
>
> Weird, that should be fixed already
>
I haven't updated in a little while, so maybe I'm looking at stale stuff.
J
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-31 0:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-30 23:58 Is this a typo? Jeremy Fitzhardinge
2006-10-31 0:06 ` Chris Wright
2006-10-31 0:12 ` Jeremy Fitzhardinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).