virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fix boot crash when freeing initrd memory
@ 2006-11-01 22:36 James Morris
  2006-11-01 22:49 ` Jeremy Fitzhardinge
  0 siblings, 1 reply; 7+ messages in thread
From: James Morris @ 2006-11-01 22:36 UTC (permalink / raw)
  To: virtualization

I'm triggering this BUG_ON during boot, which happens while freeing initrd 
memory:

 EIP is at free_init_pages+0x37/0xac
 [<c01143f1>] free_initrd_mem+0x11/0x13
 [<c03ce259>] free_initrd+0x13/0x29
 [<c03cf647>] populate_rootfs+0xdc/0xe2
 [<c01003af>] init+0x42/0x253
 [<c0103bbb>] kernel_thread_helper+0x7/0x10


I'm not sure why this memory isn't aligned now.

The patch below allows my system to boot.  Any clues about the correct fix
appreciated.


Signed-off-by: James Morris <jmorris@redhat.com>


---

 arch/i386/mm/init.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -purN -X dontdiff linux-pv-2.6.p/arch/i386/mm/init.c linux-pv-2.6.x/arch/i386/mm/init.c
--- linux-pv-2.6.p/arch/i386/mm/init.c	2006-11-01 16:46:49.000000000 -0500
+++ linux-pv-2.6.x/arch/i386/mm/init.c	2006-11-01 17:18:20.000000000 -0500
@@ -787,7 +787,7 @@ void free_init_pages(char *what, unsigne
 	unsigned long addr;
 
 	BUG_ON(begin != ALIGN(begin, PAGE_SIZE));
-	BUG_ON(end != ALIGN(end, PAGE_SIZE));
+	WARN_ON(end != ALIGN(end, PAGE_SIZE));
 
 	for (addr = begin; addr < end; addr += PAGE_SIZE) {
 		ClearPageReserved(virt_to_page(addr));

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2006-11-02  0:15 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-01 22:36 [PATCH] fix boot crash when freeing initrd memory James Morris
2006-11-01 22:49 ` Jeremy Fitzhardinge
2006-11-01 23:22   ` James Morris
2006-11-01 23:34     ` James Morris
2006-11-01 23:56       ` James Morris
2006-11-01 23:59       ` Zachary Amsden
2006-11-02  0:15         ` James Morris

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).