* APIC clock setup dependent on PAE ?
@ 2007-01-10 14:40 James Morris
2007-01-10 14:52 ` James Morris
2007-01-10 21:54 ` Zachary Amsden
0 siblings, 2 replies; 5+ messages in thread
From: James Morris @ 2007-01-10 14:40 UTC (permalink / raw)
To: virtualization
Why are these APIC clock init hooks dependent on CONFIG_X86_PAE ?
include/asm/paravirt.h:
static inline void setup_boot_clock(void)
{
paravirt_ops.setup_boot_clock();
}
static inline void setup_secondary_clock(void)
{
paravirt_ops.setup_secondary_clock();
}
(via the vmi timer patch).
- James
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: APIC clock setup dependent on PAE ?
2007-01-10 14:40 APIC clock setup dependent on PAE ? James Morris
@ 2007-01-10 14:52 ` James Morris
2007-01-10 21:54 ` Zachary Amsden
1 sibling, 0 replies; 5+ messages in thread
From: James Morris @ 2007-01-10 14:52 UTC (permalink / raw)
To: virtualization
On Wed, 10 Jan 2007, James Morris wrote:
> Why are these APIC clock init hooks dependent on CONFIG_X86_PAE ?
And should it perhaps be
#ifdef CONFIG_X86_LOCAL_APIC'd ?
- James
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: APIC clock setup dependent on PAE ?
2007-01-10 14:40 APIC clock setup dependent on PAE ? James Morris
2007-01-10 14:52 ` James Morris
@ 2007-01-10 21:54 ` Zachary Amsden
2007-01-11 0:14 ` James Morris
1 sibling, 1 reply; 5+ messages in thread
From: Zachary Amsden @ 2007-01-10 21:54 UTC (permalink / raw)
To: James Morris; +Cc: virtualization
James Morris wrote:
> Why are these APIC clock init hooks dependent on CONFIG_X86_PAE ?
>
> include/asm/paravirt.h:
>
> static inline void setup_boot_clock(void)
> {
> paravirt_ops.setup_boot_clock();
> }
>
> static inline void setup_secondary_clock(void)
> {
> paravirt_ops.setup_secondary_clock();
> }
>
>
> (via the vmi timer patch).
>
Um, that is nuts. What tree are you in?
Zach
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: APIC clock setup dependent on PAE ?
2007-01-10 21:54 ` Zachary Amsden
@ 2007-01-11 0:14 ` James Morris
2007-01-11 2:01 ` Chris Wright
0 siblings, 1 reply; 5+ messages in thread
From: James Morris @ 2007-01-11 0:14 UTC (permalink / raw)
To: Zachary Amsden; +Cc: virtualization
On Wed, 10 Jan 2007, Zachary Amsden wrote:
> Um, that is nuts. What tree are you in?
The current hg repo, with all patches applied & the current kernel
version.
- James
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: APIC clock setup dependent on PAE ?
2007-01-11 0:14 ` James Morris
@ 2007-01-11 2:01 ` Chris Wright
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wright @ 2007-01-11 2:01 UTC (permalink / raw)
To: James Morris; +Cc: virtualization
* James Morris (jmorris@namei.org) wrote:
> On Wed, 10 Jan 2007, Zachary Amsden wrote:
>
> > Um, that is nuts. What tree are you in?
>
> The current hg repo, with all patches applied & the current kernel
> version.
It's patch fuzz, I fixed it. The context wasn't enough to fail,
and it put it under the #ifdef
thanks,
-chris
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-01-11 2:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-10 14:40 APIC clock setup dependent on PAE ? James Morris
2007-01-10 14:52 ` James Morris
2007-01-10 21:54 ` Zachary Amsden
2007-01-11 0:14 ` James Morris
2007-01-11 2:01 ` Chris Wright
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).