From: Gerd Hoffmann <kraxel@suse.de>
To: Chris Wright <chrisw@sous-sol.org>
Cc: Virtualization Mailing List <virtualization@lists.osdl.org>
Subject: Re: Oops
Date: Fri, 12 Jan 2007 09:31:19 +0100 [thread overview]
Message-ID: <45A74757.5030101@suse.de> (raw)
In-Reply-To: <20070112042343.GZ10475@sequoia.sous-sol.org>
> diff -r e1974f36aa13 arch/i386/kernel/setup.c
> --- a/arch/i386/kernel/setup.c Wed Jan 10 18:19:52 2007 -0800
> +++ b/arch/i386/kernel/setup.c Thu Jan 11 18:32:22 2007 -0800
[ ... ]
> @@ -643,7 +646,7 @@ void __init setup_arch(char **cmdline_p)
>
> #ifdef CONFIG_VT
> #if defined(CONFIG_VGA_CONSOLE)
> - if (!efi_enabled || (efi_mem_type(0xa0000) != EFI_CONVENTIONAL_MEMORY))
> + if (vgacon_enabled && (!efi_enabled || (efi_mem_type(0xa0000) != EFI_CONVENTIONAL_MEMORY)))
> conswitchp = &vga_con;
> #elif defined(CONFIG_DUMMY_CONSOLE)
> conswitchp = &dummy_con;
[ ... ]
Approach looks fine to me, please put into the paravirt patch queue.
Well, maybe we can make the efi stuff just set vgacon_disabled too to
make the whole thing more readable.
Hmm, one more thing: I think we should set conswitchp to dummy_con in
case vgacon is disabled. Otherwise the vt subsystem isn't initialized
at all and we'll have problems making fbcon+pvfb work later on ...
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
next prev parent reply other threads:[~2007-01-12 8:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-09 13:34 Oops Gerd Hoffmann
2007-01-09 22:46 ` Oops Jeremy Fitzhardinge
2007-01-10 8:16 ` Oops Gerd Hoffmann
2007-01-10 10:29 ` Oops Gerd Hoffmann
2007-01-10 13:05 ` Oops Gerd Hoffmann
2007-01-10 20:07 ` Oops Jeremy Fitzhardinge
2007-01-10 23:52 ` Oops Chris Wright
2007-01-10 23:53 ` Oops Jeremy Fitzhardinge
2007-01-11 8:13 ` Oops Gerd Hoffmann
2007-01-11 8:11 ` Oops Gerd Hoffmann
2007-01-11 15:45 ` Oops Gerd Hoffmann
2007-01-11 17:41 ` Oops Chris Wright
2007-01-12 8:24 ` Oops Gerd Hoffmann
2007-01-12 2:53 ` Oops Rusty Russell
2007-01-12 4:23 ` Oops Chris Wright
2007-01-12 8:31 ` Gerd Hoffmann [this message]
2007-01-10 20:06 ` Oops Jeremy Fitzhardinge
2007-01-10 21:44 ` Oops Jeremy Fitzhardinge
2007-01-11 14:12 ` Oops Gerd Hoffmann
2007-01-11 19:56 ` Oops Jeremy Fitzhardinge
2007-01-10 19:38 ` Oops Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A74757.5030101@suse.de \
--to=kraxel@suse.de \
--cc=chrisw@sous-sol.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).