From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [patch 15/21] Xen-paravirt: Add Xen interface header files Date: Wed, 14 Feb 2007 16:10:50 -0800 Message-ID: <45D3A50A.9090303@goop.org> References: <20070213221729.772002682@goop.org> <20070213221830.619562494@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Eric W. Biederman" Cc: Andrew Morton , xen-devel@lists.xensource.com, Ian Pratt , linux-kernel@vger.kernel.org, Chris Wright , Andi Kleen , virtualization@lists.osdl.org List-Id: virtualization@lists.linuxfoundation.org Eric W. Biederman wrote: > Jeremy Fitzhardinge writes: > > >> Add Xen interface header files. These are taken fairly directly from >> the Xen tree and hence the style is not entirely in accordance with >> Linux guidelines. There is a tension between fitting with Linux coding >> rules and ease of maintenance. >> >> Define macros and inline functions for doing hypercalls into the >> hypervisor. >> >> Signed-off-by: Jeremy Fitzhardinge >> Signed-off-by: Ian Pratt >> Signed-off-by: Christian Limpach >> Signed-off-by: Chris Wright >> >> >> -- >> include/asm-i386/hypercall.h | 416 +++++++++++++++++++++++++++++ >> include/asm-i386/hypervisor.h | 72 +++++ >> > > Are hypercall.h and hypervisor.h generic or are they Xen specific. > If they are Xen specific (as it appears) then are inappropriately > named. > Thanks for the reminder; I've been meaning to move/rename these. >> include/xen/interface/arch-x86_32.h | 187 +++++++++++++ >> > Why isn't this file include-asm-i386/xen/arch-x86_32.h ? > Those files are more or less directly copied from the Xen tree, and its easier if they don't drift too far in name and directory structure. J