From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Keir Fraser <keir@xensource.com>
Cc: Zachary Amsden <zach@vmware.com>,
xen-devel@lists.xensource.com,
Ian Pratt <ian.pratt@xensource.com>,
virtualization@lists.osdl.org, linux-kernel@vger.kernel.org,
Jan Beulich <JBeulich@novell.com>,
Chris Wright <chrisw@sous-sol.org>, Andi Kleen <ak@muc.de>,
Andrew Morton <akpm@linux-foundation.org>,
Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
Subject: Re: Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas
Date: Fri, 16 Feb 2007 09:27:39 -0800 [thread overview]
Message-ID: <45D5E98B.4070904@goop.org> (raw)
In-Reply-To: <C1FB967F.998B%keir@xensource.com>
Keir Fraser wrote:
> On 16/2/07 17:10, "Keir Fraser" <keir@xensource.com> wrote:
>
>
>> On 16/2/07 16:46, "Jeremy Fitzhardinge" <jeremy@goop.org> wrote:
>>
>>
>>> Yes, that would work. Unfortunately that's i386 arch-specific, whereas
>>> the rest of this code is generic. I guess I could just move it all to
>>> arch/i386/mm.
>>>
>> This whole thing isn't an issue on ia64 (they no-op lock_vm_area) and
>> powerpc doesn't use any of the Xen driver code at this time.
>> vmalloc_sync_all is supported by both i386 and x86_64, so we can make the
>> call conditional on CONFIG_X86 so that ia64 will continue to build. This is
>> what I've done in xen-unstable.
>>
>
>
> In fact that file is only built for i386 and x86_64, so there really is no
> problem with using vmalloc_sync_all() directly and without ifdef.
>
I had moved it to mm/vmalloc.c in response to previous review comments
(namely, its not Xen specific, so it shouldn't live in the Xen part of
the tree).
J
next parent reply other threads:[~2007-02-16 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C1FB967F.998B%keir@xensource.com>
2007-02-16 17:27 ` Jeremy Fitzhardinge [this message]
2007-02-16 19:06 ` [Xen-devel] Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas Keir Fraser
2007-02-16 19:06 ` Keir Fraser
[not found] <C1FBB152.99B0%keir@xensource.com>
2007-02-16 19:19 ` Keir Fraser
2007-02-16 19:26 ` Jeremy Fitzhardinge
2007-02-16 23:29 ` Keir Fraser
2007-02-16 23:41 ` Jeremy Fitzhardinge
[not found] <C1FB9605.9988%keir@xensource.com>
2007-02-16 17:26 ` Hollis Blanchard
[not found] <C1FB4190.98FA%keir@xensource.com>
2007-02-16 11:34 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D5E98B.4070904@goop.org \
--to=jeremy@goop.org \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=JBeulich@novell.com \
--cc=ak@muc.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=ian.pratt@xensource.com \
--cc=keir@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).