From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Zachary Amsden <zach@vmware.com>,
xen-devel@lists.xensource.com, virtualization@lists.osdl.org,
linux-kernel@vger.kernel.org, Chris Wright <chrisw@sous-sol.org>,
Andi Kleen <ak@muc.de>, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache
Date: Fri, 16 Feb 2007 15:33:09 -0800 [thread overview]
Message-ID: <45D63F35.3000101@goop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702161229360.26650@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> On Thu, 15 Feb 2007, Jeremy Fitzhardinge wrote:
>
>
>> Remove the ctor for the pgd cache. There's no point in having the
>> cache machinery do this via an indirect call when all pgd are freed in
>> the one place anyway.
>>
>
> Great. We finally get rid of this evil .....
>
> On second throughts:
>
> Are you sure that you understand what you are modifying? The ctor is not
> called when you allocate an object but when the slab allocates it. Freeing
> an object does not make the slab free it. It will hold it for the next
> kmalloc. So you may just have reduced performance somewhat by addiung
> additional ctor processing and possibly disturbed the preservation of
> cache hot pgds.
It's true I wrote this patch as a result of accidentally reading slob.c
rather than slab.c, which was mostly as a result of hopeful thinking (I
knew that there has been discussion about removing all the slab cache
stuff, and I assumed that it had already happened). As a result I'm
withdrawing this patch for now, but with any luck it will be useful at
some point.
J
next prev parent reply other threads:[~2007-02-16 23:33 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 2:24 [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface Jeremy Fitzhardinge
2007-02-16 2:24 ` [patch 01/21] Xen-paravirt: Fix typo in sync_constant_test_bit()s name Jeremy Fitzhardinge
2007-02-16 2:24 ` [patch 02/21] Xen-paravirt: ignore vgacon if hardware not present Jeremy Fitzhardinge
2007-02-16 2:24 ` [patch 03/21] Xen-paravirt: Add pagetable accessors to pack and unpack pagetable entries Jeremy Fitzhardinge
2007-02-16 2:24 ` [patch 04/21] Xen-paravirt: =================================================================== Jeremy Fitzhardinge
2007-02-16 9:12 ` Andi Kleen
2007-02-16 17:32 ` Jeremy Fitzhardinge
2007-02-16 2:24 ` [patch 05/21] Xen-paravirt: paravirt_ops: hooks to set up initial pagetable Jeremy Fitzhardinge
2007-02-16 2:24 ` [patch 06/21] Xen-paravirt: paravirt_ops: allocate a fixmap slot Jeremy Fitzhardinge
2007-02-16 2:24 ` [patch 07/21] Xen-paravirt: remove ctor for pgd cache Jeremy Fitzhardinge
2007-02-16 6:04 ` Zachary Amsden
2007-02-16 8:39 ` Pekka Enberg
2007-02-16 9:19 ` Nick Piggin
2007-02-16 17:19 ` Jeremy Fitzhardinge
2007-02-16 20:33 ` Christoph Lameter
2007-02-16 23:33 ` Jeremy Fitzhardinge [this message]
2007-02-16 2:24 ` [patch 08/21] Xen-paravirt: Allow paravirt backend to choose kernel PMD sharing Jeremy Fitzhardinge
2007-02-16 2:24 ` [patch 09/21] Xen-paravirt: Allow paravirt backend to select PGD allocation alignment Jeremy Fitzhardinge
2007-02-16 2:24 ` [patch 10/21] Xen-paravirt: add hooks to intercept mm creation and destruction Jeremy Fitzhardinge
2007-02-16 6:34 ` Andrew Morton
2007-02-16 6:55 ` Jeremy Fitzhardinge
2007-02-22 20:16 ` Pavel Machek
2007-02-22 20:21 ` Jeremy Fitzhardinge
2007-02-22 20:23 ` Jeremy Fitzhardinge
2007-02-16 2:25 ` [patch 11/21] Xen-paravirt: Add apply_to_page_range() which applies a function to a pte range Jeremy Fitzhardinge
2007-02-16 6:37 ` Andrew Morton
2007-02-16 7:06 ` Jeremy Fitzhardinge
2007-02-16 7:19 ` Andrew Morton
2007-02-16 7:23 ` Jeremy Fitzhardinge
2007-02-16 7:31 ` Nick Piggin
2007-02-16 2:25 ` [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas Jeremy Fitzhardinge
2007-02-16 6:43 ` Andrew Morton
2007-02-16 7:08 ` Jeremy Fitzhardinge
2007-02-16 7:24 ` Andrew Morton
2007-02-16 7:30 ` Jeremy Fitzhardinge
2007-02-16 7:49 ` Andrew Morton
2007-02-16 9:18 ` Andi Kleen
2007-02-16 11:10 ` [Xen-devel] " Keir Fraser
2007-02-16 11:10 ` Keir Fraser
2007-02-16 16:46 ` Jeremy Fitzhardinge
2007-02-16 17:10 ` [Xen-devel] " Keir Fraser
2007-02-16 17:10 ` Keir Fraser
2007-02-16 7:48 ` Nick Piggin
2007-02-16 2:25 ` [patch 13/21] Xen-paravirt: Add nosegneg capability to the vsyscall page notes Jeremy Fitzhardinge
2007-02-16 6:06 ` Zachary Amsden
2007-02-16 2:25 ` [patch 14/21] Xen-paravirt: Add XEN config options and disable unsupported config options Jeremy Fitzhardinge
2007-02-16 6:14 ` Dan Hecht
2007-02-16 7:04 ` Jeremy Fitzhardinge
2007-02-16 7:52 ` Dan Hecht
2007-02-16 8:05 ` Jeremy Fitzhardinge
2007-02-16 8:37 ` Dan Hecht
2007-02-16 10:49 ` Keir Fraser
2007-02-16 10:49 ` Keir Fraser
2007-02-16 7:06 ` Andrew Morton
2007-02-16 7:25 ` Jeremy Fitzhardinge
2007-02-16 10:09 ` Keir Fraser
2007-02-16 10:19 ` Zachary Amsden
2007-02-16 10:44 ` [Xen-devel] " Keir Fraser
2007-02-16 10:55 ` Zachary Amsden
2007-02-17 4:04 ` Rusty Russell
2007-02-16 6:15 ` Zachary Amsden
2007-02-16 7:33 ` Eric W. Biederman
2007-02-16 8:14 ` Ian Campbell
2007-02-16 8:24 ` Eric W. Biederman
2007-02-16 8:31 ` Zachary Amsden
2007-02-16 13:53 ` Gerd Hoffmann
2007-02-18 11:32 ` Avi Kivity
2007-02-16 2:25 ` [patch 15/21] Xen-paravirt: Add Xen interface header files Jeremy Fitzhardinge
2007-02-16 2:25 ` [patch 16/21] Xen-paravirt: Core Xen implementation Jeremy Fitzhardinge
2007-02-16 2:25 ` [patch 17/21] Xen-paravirt: Add the Xen virtual console driver Jeremy Fitzhardinge
2007-02-16 6:48 ` Andrew Morton
2007-02-16 2:25 ` [patch 18/21] Xen-paravirt: Add Xen grant table support Jeremy Fitzhardinge
2007-02-16 6:52 ` Andrew Morton
2007-02-16 6:58 ` Jeremy Fitzhardinge
2007-02-16 2:25 ` [patch 19/21] Xen-paravirt: Add the Xenbus sysfs and virtual device hotplug driver Jeremy Fitzhardinge
2007-02-16 2:25 ` [patch 20/21] Xen-paravirt: Add Xen virtual block device driver Jeremy Fitzhardinge
2007-02-16 2:25 ` [patch 21/21] Xen-paravirt: Add the Xen virtual network " Jeremy Fitzhardinge
2007-02-16 6:59 ` [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface Andrew Morton
2007-02-16 7:20 ` Jeremy Fitzhardinge
2007-02-16 20:49 ` Christoph Lameter
2007-02-16 21:04 ` Zachary Amsden
2007-02-16 21:13 ` Christoph Lameter
2007-02-16 21:48 ` Zachary Amsden
2007-02-16 21:59 ` Christoph Lameter
2007-02-16 22:10 ` Zachary Amsden
2007-02-17 13:51 ` Andi Kleen
2007-02-21 18:37 ` Christoph Lameter
2007-02-21 18:55 ` Zachary Amsden
2007-02-21 20:02 ` Jeremy Fitzhardinge
2007-02-17 5:05 ` Rusty Russell
2007-02-16 23:49 ` Jeremy Fitzhardinge
2007-02-17 4:58 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D63F35.3000101@goop.org \
--to=jeremy@goop.org \
--cc=ak@muc.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).