From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com, virtualization@lists.osdl.org,
linux-kernel@vger.kernel.org, Jan Beulich <JBeulich@novell.com>,
Chris Wright <chrisw@sous-sol.org>,
Ian Pratt <ian.pratt@xensource.com>,
Andrew Morton <akpm@linux-foundation.org>,
Keir Fraser <keir@xensource.com>, Andi Kleen <ak@muc.de>
Subject: Re: Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas
Date: Fri, 16 Feb 2007 15:41:53 -0800 [thread overview]
Message-ID: <45D64141.90307@goop.org> (raw)
In-Reply-To: <C1FBEEF5.2256%Keir.Fraser@cl.cam.ac.uk>
Keir Fraser wrote:
> It has no other users right now and get_vm_area_sync() would be a
> better-named and more generically useful function than alloc_vm_area().
I'm thinking "reserve" might be a better term; "get" generally has the
suggestion of a refcount.
> get_vm_area_sync(), partnered with existing remove_vm_area(), just seems
> much smaller and neater than adding four new functions with a more complex
> usage: alloc_vm_area, {lock,unlock}_vm_area, and free_vm_area. Maybe keeping
> free_vm_area() too makes sense as its interface is more neatly symmetrical
> to that of get_vm_area().
I've already killed the lock/unlock functions. I'll come up with
something for the get/allocate/reserve and free functions.
J
next prev parent reply other threads:[~2007-02-16 23:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C1FBB152.99B0%keir@xensource.com>
2007-02-16 19:19 ` Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas Keir Fraser
2007-02-16 19:26 ` Jeremy Fitzhardinge
2007-02-16 23:29 ` Keir Fraser
2007-02-16 23:41 ` Jeremy Fitzhardinge [this message]
[not found] <C1FB967F.998B%keir@xensource.com>
2007-02-16 17:27 ` Jeremy Fitzhardinge
[not found] <C1FB9605.9988%keir@xensource.com>
2007-02-16 17:26 ` Hollis Blanchard
[not found] <C1FB4190.98FA%keir@xensource.com>
2007-02-16 11:34 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D64141.90307@goop.org \
--to=jeremy@goop.org \
--cc=JBeulich@novell.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=ak@muc.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=ian.pratt@xensource.com \
--cc=keir@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).