From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [patch 16/26] Xen-paravirt_ops: Allocate and free vmalloc areas Date: Fri, 16 Mar 2007 10:05:50 -0700 Message-ID: <45FACE6E.3000901@goop.org> References: <20070301232443.195603797@goop.org> <20070301232528.297902504@goop.org> <20070316091648.GI23174@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070316091648.GI23174@elte.hu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ingo Molnar Cc: Zachary Amsden , xen-devel@lists.xensource.com, Ian Pratt , virtualization@lists.osdl.org, Rusty Russell , linux-kernel@vger.kernel.org, Jan Beulich , Chris Wright , Andi Kleen , Andrew Morton , Christian Limpach List-Id: virtualization@lists.linuxfoundation.org Ingo Molnar wrote: >> +struct vm_struct *alloc_vm_area(unsigned long size) >> > > this should go into mm/vmalloc.c. The trouble is that it calls the arch-dependent vmalloc_sync_all(), which is important for Xen's use of this function. And without that it's just a pointless wrapper around get_vm_area. J