From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [patch 12/26] Xen-paravirt_ops: Fix patch site clobbers to include return register Date: Fri, 16 Mar 2007 10:37:44 -0700 Message-ID: <45FAD5E8.1030301@goop.org> References: <20070301232443.195603797@goop.org> <20070301232527.755495278@goop.org> <20070316092626.GN23174@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070316092626.GN23174@elte.hu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ingo Molnar Cc: Zachary Amsden , xen-devel@lists.xensource.com, virtualization@lists.osdl.org, Rusty Russell , linux-kernel@vger.kernel.org, Chris Wright , Andi Kleen , Andrew Morton , Linus Torvalds List-Id: virtualization@lists.linuxfoundation.org Ingo Molnar wrote: > * Jeremy Fitzhardinge wrote: > > >> Fix a few clobbers to include the return register. The clobbers set >> is the set of all registers modified (or may be modified) by the code >> snippet, regardless of whether it was deliberate or accidental. >> > > i guess we need these paravirt.h clobber fixes for v2.6.21 (VMI) too, > correct? No, I don't think so. These aren't gcc-style clobbers, but a marker in the .parainstruction section about what registers may be clobbered by the patched in code. VMI doesn't use that info, and/or doesn't clobber more than is allowed at each site, so it isn't an issue. J