From: "Jan Beulich" <jbeulich@novell.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
virtualization@lists.osdl.org, Roland McGrath <roland@redhat.com>,
Andi Kleen <ak@suse.de>, lkml <linux-kernel@vger.kernel.org>,
Zachary Amsden <zach@vmware.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [patch 1/2] Relocate VDSO ELF headers to match mapped location with COMPAT_VDSO
Date: Thu, 05 Apr 2007 09:54:56 +0100 [thread overview]
Message-ID: <4614D580.76E4.0078.0@novell.com> (raw)
In-Reply-To: <4614B0DB.7040003@goop.org>
>+ for(; dyn->d_tag != DT_NULL; dyn++)
>+ switch(dyn->d_tag) {
>+ case DT_PLTGOT:
>+ case DT_HASH:
>+ case DT_STRTAB:
>+ case DT_SYMTAB:
>+ case DT_RELA:
>+ case DT_INIT:
>+ case DT_FINI:
>+ case DT_REL:
>+ case DT_DEBUG:
>+ case DT_JMPREL:
>+ case DT_VERSYM:
>+ case DT_VERDEF:
>+ case DT_VERNEED:
>+ case DT_ENCODING ... DT_HIOS:
>+ /* tags above DT_ENCODING are even if they're
>+ a pointer, so skip odd ones */
>+ if (dyn->d_tag >= DT_ENCODING &&
>+ (dyn->d_tag & 1) == 1)
>+ break;
>+
>+ dyn->d_un.d_ptr += VDSO_HIGH_BASE;
>+ }
I'm pretty certain the range OLD_DT_LOOS ... DT_LOOS must be excluded
here (the document version I'm looking at is inconsistent in itself here, saying
in one place to stop at DT_LOOS, in a second to stop at DT_HIOS, and in a
third to include DT_LOOS ... ST_HIOS - the inconsistency goes away if
assuming that the stop at DT_LOOS really means stop at OLD_DT_LOOS,
and the stop at DT_HIOS misses to special-case the OLD_DT_LOOS ...
DT_LOOS range.
Additionally I'm a little worried about excluding DT_ADDRRNGLO ...
DT_ADDRRNGHI in case future binutils ever start defaulting to generate
any of these (namely DT_GNU_HASH).
>+#define DT_ENCODING 32
Hmm, I was about to say this ought to be 31 when I realized the discrepancy
between document and binutils. I'll have to ask about this...
Jan
next prev parent reply other threads:[~2007-04-05 8:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 4:58 [patch 0/2] Updates to compat VDSOs Jeremy Fitzhardinge
2007-04-05 4:58 ` [patch 1/2] Relocate VDSO ELF headers to match mapped location with COMPAT_VDSO Jeremy Fitzhardinge
2007-04-05 6:31 ` Roland McGrath
2007-04-05 6:46 ` Jeremy Fitzhardinge
2007-04-05 8:14 ` Roland McGrath
2007-04-05 7:10 ` Jan Beulich
2007-04-05 7:31 ` Jeremy Fitzhardinge
2007-04-05 7:45 ` Raharjo, Cahyo (cahr)
2007-04-05 7:47 ` Jan Beulich
2007-04-05 8:14 ` Roland McGrath
2007-04-05 8:18 ` Jeremy Fitzhardinge
2007-04-05 8:54 ` Jan Beulich [this message]
2007-04-05 8:58 ` Roland McGrath
2007-04-05 4:58 ` [patch 2/2] Make COMPAT_VDSO runtime selectable Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2007-04-05 15:53 [patch 0/2] Updates to compat VDSOs Jeremy Fitzhardinge
2007-04-05 15:53 ` [patch 1/2] Relocate VDSO ELF headers to match mapped location with COMPAT_VDSO Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4614D580.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).