From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH 1/2] Clean up asm-x86_64/bugs.h Date: Mon, 09 Apr 2007 08:48:29 -0700 Message-ID: <461A604D.7050903@goop.org> References: <4617D339.3080801@goop.org> <20070409084557.28748317.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20070409084557.28748317.randy.dunlap@oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Randy Dunlap Cc: Andrew Morton , Virtualization Mailing List , Linus Torvalds , Linux Kernel Mailing List List-Id: virtualization@lists.linuxfoundation.org Randy Dunlap wrote: > On Sat, 07 Apr 2007 10:22:01 -0700 Jeremy Fitzhardinge wrote: > > = >> Most of asm-x86_64/bugs.h is code which should be in a C file, so put it= there. >> >> Signed-off-by: Jeremy Fitzhardinge >> Cc: Andi Kleen >> Cc: Linus Torvalds >> >> --- >> arch/x86_64/kernel/Makefile | 3 ++- >> arch/x86_64/kernel/bugs.c | 28 ++++++++++++++++++++++++++++ >> include/asm-x86_64/alternative.h | 1 + >> include/asm-x86_64/bugs.h | 30 ++++-------------------------- >> 4 files changed, 35 insertions(+), 27 deletions(-) >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- /dev/null >> +++ b/arch/x86_64/kernel/bugs.c >> @@ -0,0 +1,28 @@ >> +/* >> + * arch/x86_64/kernel/bugs.c >> + * >> + * Copyright (C) 1994 Linus Torvalds >> + * Copyright (C) 2000 SuSE >> + * >> + * This is included by init/main.c to check for architecture-dependent = bugs. >> = > > drop comment. > > Are you going to tackle asm-i386/bugs.h also? Yes, I'd already sent it out. This was just the response to "please make them consistent". J