* [PATCH 1/10] I386 sysenter arch pages fix.patch
@ 2007-04-10 0:06 Zachary Amsden
2007-04-10 5:23 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 2+ messages in thread
From: Zachary Amsden @ 2007-04-10 0:06 UTC (permalink / raw)
To: Andrew Morton, Andi Kleen, Jeremy Fitzhardinge, Rusty Russell,
Chris Wright, Virtualization Mailing List,
Linux Kernel Mailing List, Zachary Amsden
In compat mode, the return value here was uninitialized.
Signed-off-by: Zachary Amsden <zach@vmware.com>
diff -r 1fda49a076ed arch/i386/kernel/sysenter.c
--- a/arch/i386/kernel/sysenter.c Fri Apr 06 14:25:09 2007 -0700
+++ b/arch/i386/kernel/sysenter.c Fri Apr 06 14:27:31 2007 -0700
@@ -254,7 +254,7 @@ int arch_setup_additional_pages(struct l
{
struct mm_struct *mm = current->mm;
unsigned long addr;
- int ret;
+ int ret = 0;
bool compat;
down_write(&mm->mmap_sem);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/10] I386 sysenter arch pages fix.patch
2007-04-10 0:06 [PATCH 1/10] I386 sysenter arch pages fix.patch Zachary Amsden
@ 2007-04-10 5:23 ` Jeremy Fitzhardinge
0 siblings, 0 replies; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2007-04-10 5:23 UTC (permalink / raw)
To: Zachary Amsden
Cc: Andrew Morton, Andi Kleen, Rusty Russell, Chris Wright,
Virtualization Mailing List, Linux Kernel Mailing List
Zachary Amsden wrote:
> In compat mode, the return value here was uninitialized.
>
> Signed-off-by: Zachary Amsden <zach@vmware.com>
>
> diff -r 1fda49a076ed arch/i386/kernel/sysenter.c
> --- a/arch/i386/kernel/sysenter.c Fri Apr 06 14:25:09 2007 -0700
> +++ b/arch/i386/kernel/sysenter.c Fri Apr 06 14:27:31 2007 -0700
> @@ -254,7 +254,7 @@ int arch_setup_additional_pages(struct l
> {
> struct mm_struct *mm = current->mm;
> unsigned long addr;
> - int ret;
> + int ret = 0;
> bool compat;
>
> down_write(&mm->mmap_sem);
> -
Hm, OK, but what about just zeroing it in the compat leg of the if()?
J
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-10 5:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-10 0:06 [PATCH 1/10] I386 sysenter arch pages fix.patch Zachary Amsden
2007-04-10 5:23 ` Jeremy Fitzhardinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).