From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Chris Wright <chrisw@sous-sol.org>, Andrew Morton <akpm@osdl.org>,
Andi Kleen <ak@muc.de>, Thomas Gleixner <tglx@linutronix.de>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 9/10] Vmi timer update.patch
Date: Tue, 10 Apr 2007 15:16:20 -0700 [thread overview]
Message-ID: <461C0CB4.9000407@goop.org> (raw)
In-Reply-To: <461C084C.9020009@vmware.com>
Zachary Amsden wrote:
> /*
> * Avoid unnecessary state transitions, as it confuses
> * Geode / Cyrix based boxen.
> */
> case CLOCK_EVT_MODE_SHUTDOWN:
> if (evt->mode == CLOCK_EVT_MODE_UNUSED)
> break;
> case CLOCK_EVT_MODE_UNUSED:
> if (evt->mode == CLOCK_EVT_MODE_SHUTDOWN)
> break;
> case CLOCK_EVT_MODE_ONESHOT:
> /* One shot setup */
> outb_p(0x38, PIT_MODE);
>
> So switching from PIT to VMI does not disable PIT timer interrupts.
> Thus I have to keep this part of the patch.
Why not submit a patch to do what you need here? (The Geode comment is
a bit worrying though.)
J
next prev parent reply other threads:[~2007-04-10 22:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 0:06 [PATCH 9/10] Vmi timer update.patch Zachary Amsden
2007-04-10 2:37 ` Chris Wright
2007-04-10 17:03 ` Zachary Amsden
2007-04-10 17:24 ` Chris Wright
2007-04-10 21:57 ` Zachary Amsden
2007-04-10 22:16 ` Jeremy Fitzhardinge [this message]
2007-04-10 22:28 ` Zachary Amsden
2007-04-10 22:38 ` Chris Wright
2007-04-10 22:28 ` Chris Wright
2007-04-10 22:59 ` Zachary Amsden
2007-04-12 1:19 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461C0CB4.9000407@goop.org \
--to=jeremy@goop.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).