From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>, Petr Vandrovec <petr@vmware.com>,
Chaz Masden <zamsden@gmail.com>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Chris Wright <chrisw@sous-sol.org>, Andi Kleen <ak@muc.de>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [RFC, PATCH 2/5] Paravirt_ops patch bugs.patch
Date: Thu, 19 Apr 2007 21:39:34 -0700 [thread overview]
Message-ID: <46284406.2080007@goop.org> (raw)
In-Reply-To: <20070420015234.5D42EBFC@zach-dev2.vmware.com>
Zachary Amsden wrote:
> Failing to patch because not enough space is available for a call or jump
> or because the site clobbers do not allow the target clobbers to fit is
> a fatal error; it means the kernel can not be properly virtualized.
>
No, that doesn't follow. If the original site was:
patchable_start:
push %eax
push %ecx
push %edx
call *paravirt_ops + thingy
pop
pop
pop
patchable_end:
then its perfectly OK to leave it as-is, even if the direct call's
destination clobbers are mismatched. If the patcher wants to generate a
call to a C function in a context which can't deal with normal C calling
conventions, then it needs to also patch in appropriate save/restores.
J
next prev parent reply other threads:[~2007-04-20 4:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 1:52 [RFC, PATCH 2/5] Paravirt_ops patch bugs.patch Zachary Amsden
2007-04-20 4:39 ` Jeremy Fitzhardinge [this message]
2007-04-20 5:09 ` Zachary Amsden
2007-04-20 5:19 ` Jeremy Fitzhardinge
2007-04-20 5:28 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46284406.2080007@goop.org \
--to=jeremy@goop.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=mingo@elte.hu \
--cc=petr@vmware.com \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
--cc=zamsden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).