From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>, Petr Vandrovec <petr@vmware.com>,
Chaz Masden <zamsden@gmail.com>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Chris Wright <chrisw@sous-sol.org>, Andi Kleen <ak@muc.de>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [RFC, PATCH 5/5] Paravirt_ops export.patch
Date: Thu, 19 Apr 2007 22:10:24 -0700 [thread overview]
Message-ID: <46284B40.5010106@goop.org> (raw)
In-Reply-To: <20070420015304.74394BFC@zach-dev2.vmware.com>
Zachary Amsden wrote:
> Now that paravirt-ops is a fully patched, purely functional interface,
> which appropriately generates bugs when patches fail to get applied,
> it need no longer be exported to modules. Modules will be patched at
> load time, and need no boot time fallback which references paravirt-ops.
>
Hm, OK, I see what you're getting at.
I guess the BUG_ON()s need only fire if they're failing to patch over a
ud2a instruction.
I'm in two minds about this. On the one hand, it's a clever hack which
does achieve the desired outcome. On the other hand, it turns an
optimisation mechanism into a special-purpose ad-hoc linker which
doesn't seem like quite the right way to go. The conversion from "best
effort, doing nothing is OK" to "doing nothing is a BUG" behaviour is a
good indication of this.
J
next prev parent reply other threads:[~2007-04-20 5:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 1:53 [RFC, PATCH 5/5] Paravirt_ops export.patch Zachary Amsden
2007-04-20 5:10 ` Jeremy Fitzhardinge [this message]
2007-04-22 14:28 ` Eric W. Biederman
2007-04-22 16:20 ` Jeremy Fitzhardinge
2007-04-22 16:59 ` Zachary Amsden
2007-04-22 17:31 ` Jeremy Fitzhardinge
2007-04-23 20:53 ` Zachary Amsden
2007-04-23 21:14 ` Eric W. Biederman
2007-04-23 21:40 ` Zachary Amsden
2007-04-23 21:29 ` Jeremy Fitzhardinge
2007-04-23 21:54 ` Zachary Amsden
2007-04-23 22:15 ` Jeremy Fitzhardinge
2007-04-23 22:24 ` Zachary Amsden
2007-04-23 22:29 ` Andi Kleen
2007-04-22 23:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46284B40.5010106@goop.org \
--to=jeremy@goop.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=mingo@elte.hu \
--cc=petr@vmware.com \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
--cc=zamsden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).