From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 06/12] i386: Minimum cpu detection cleanups. Date: Mon, 30 Apr 2007 09:13:46 -0700 Message-ID: <463615BA.4020703@zytor.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Andrew Morton , virtualization List-Id: virtualization@lists.linuxfoundation.org Eric W. Biederman wrote: > > diff --git a/arch/i386/kernel/verify_cpu.S b/arch/i386/kernel/verify_cpu.S > index ba9e03e..e51a869 100644 > --- a/arch/i386/kernel/verify_cpu.S > +++ b/arch/i386/kernel/verify_cpu.S > @@ -4,10 +4,6 @@ > #include > > verify_cpu: > -#if REQUIRED_MASK1 == 0 > - xorl %eax,%eax > - ret > -#endif > pushfl # Save caller passed flags > pushl $0 # Kill any dangerous flags > popfl > @@ -21,7 +17,7 @@ verify_cpu: > testl $(1<<18),%eax ^^^^^^^ > jz bad While you're in there can you change references to the flags to use the constants? -hpa