From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Roland McGrath <roland@redhat.com>
Cc: Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
virtualization@lists.osdl.org,
lkml <linux-kernel@vger.kernel.org>,
Chris Wright <chrisw@sous-sol.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Ian Pratt <ian.pratt@xensource.com>,
Christian Limpach <Christian.Limpach@cl.cam.ac.uk>,
Zachary Amsden <zach@vmware.com>,
Ulrich Drepper <drepper@redhat.com>
Subject: Re: [patch 02/28]xen: Add nosegneg capability to the vsyscall page notes
Date: Fri, 11 May 2007 13:25:00 -0700 [thread overview]
Message-ID: <4644D11C.2040207@goop.org> (raw)
In-Reply-To: <20070511200744.4BC1A1F8512@magilla.localdomain>
Roland McGrath wrote:
>> + * It should contain:
>> + * hwcap 0 nosegneg
>> + * to match the mapping of bit to name that we give here.
>>
>
> This comment still needs s/0/1/ to match the code. Given that the actual
> bit is now defined in the macro in another file, perhaps the comment should
> say more about it than just a magic 1.
>
Crap, I thought I had 1) understood it, and 2) fixed it. I guess I
skipped 1 and therefore overlooked 2.
J
next prev parent reply other threads:[~2007-05-11 20:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 0:06 [patch 00/28]xen: Xen implementation for paravirt_ops Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 01/28]xen: Allocate and free vmalloc areas Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 02/28]xen: Add nosegneg capability to the vsyscall page notes Jeremy Fitzhardinge
2007-05-11 20:07 ` Roland McGrath
2007-05-11 20:25 ` Jeremy Fitzhardinge [this message]
2007-05-11 0:06 ` [patch 03/28]xen: Add Xen interface header files Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 04/28]xen: Core Xen implementation Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 05/28]xen: Xen virtual mmu Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 06/28]xen: xen event channels Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 07/28]xen: xen time implementation Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 08/28]xen: xen configuration Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 09/28]xen: Complete pagetable pinning for Xen Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 10/28]xen: ignore RW mapping of RO pages in pagetable_init Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 11/28]xen: fix multicall batching Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 12/28]xen: Account for time stolen by Xen Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 13/28]xen: Implement xen_sched_clock Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 14/28]xen: Xen SMP guest support Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 15/28]xen: Add support for preemption Jeremy Fitzhardinge
2007-05-11 0:06 ` [patch 16/28]xen: lazy-mmu operations Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 17/28]xen: deal with negative stolen time Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 18/28]xen: Use the hvc console infrastructure for Xen console Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 19/28]xen: Add early printk support via hvc console Jeremy Fitzhardinge
2007-05-12 19:08 ` [Xen-devel] " Bastian Blank
2007-05-12 19:57 ` Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 20/28]xen: Add Xen grant table support Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 21/28]xen: Add the Xenbus sysfs and virtual device hotplug driver Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 22/28]xen: Add Xen virtual block device driver Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 23/28]xen: rename xen netif_ structures to xen_netif_ Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 24/28]xen: Add the Xen virtual network device driver Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 25/28]xen: Xen machine operations Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 26/28]xen: handle external requests for shutdown, reboot and sysrq Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 27/28]xen: Place vcpu_info structure into per-cpu memory, if possible Jeremy Fitzhardinge
2007-05-11 0:07 ` [patch 28/28]xen: Attempt to patch inline versions of common operations Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4644D11C.2040207@goop.org \
--to=jeremy@goop.org \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=drepper@redhat.com \
--cc=ian.pratt@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).