From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/3] KVM paravirt_ops infrastructure Date: Thu, 31 May 2007 10:48:28 +0300 Message-ID: <465E7DCC.1040703@qumranet.com> References: <465D8F03.7000201@us.ibm.com> <465D8FA7.9050600@us.ibm.com> <1180573347.30202.135.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1180573347.30202.135.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Rusty Russell Cc: kvm-devel , virtualization List-Id: virtualization@lists.linuxfoundation.org Rusty Russell wrote: > Two versions, size *and* ret? This seems like overkill... > > I think we ought to move away from version numbers and use feature availability flags instead. >> + if (rc) { >> + printk(KERN_INFO "paravirt KVM unavailable\n"); >> > > Double-printk when KVM isn't detected seems overkill. Perhaps you could > just fold this all into one function... > > (Personal gripe: I consider a variable named "rc" to be an admission of > semantic defeat... "err" would be better here...) > I just use 'r' (short for 'argh'). -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/