From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH 4/5] KVM: Add hypercall queue for paravirt_ops implementation Date: Sun, 17 Jun 2007 21:09:31 -0700 Message-ID: <4676057B.7060503@goop.org> References: <4675F462.1010708@codemonkey.ws> <4675F568.90608@codemonkey.ws> <46760343.5070401@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <46760343.5070401-TSDbQ3PG+2Y@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jeremy Fitzhardinge Cc: kvm-devel , virtualization List-Id: virtualization@lists.linuxfoundation.org Jeremy Fitzhardinge wrote: >> +static int kvm_hypercall_flush(struct kvm_vcpu *vcpu) >> +{ >> + struct kvm_hypercall_entry *queue; >> + struct kvm_vmca *vmca; >> + int ret = 0; >> + int i; >> + >> + queue = kmap(vcpu->queue_page); >> + vmca = kmap(vcpu->para_state_page); >> >> > > kmap_atomic? Or why not keep them mapped all the time? > Oh, right, this is on the kvm side. Still, kmap_atomic? J ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/