From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/5] KVM: Add paravirt MMU write support Date: Mon, 18 Jun 2007 11:20:49 +0300 Message-ID: <46764061.9080705@qumranet.com> References: <4675F462.1010708@codemonkey.ws> <4675F533.40809@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4675F533.40809-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Anthony Liguori Cc: kvm-devel , virtualization List-Id: virtualization@lists.linuxfoundation.org Anthony Liguori wrote: > +static int kvm_hypercall_mmu_write(struct kvm_vcpu *vcpu, gva_t addr, > + unsigned long size, unsigned long a0, > + unsigned long a1) > +{ > + gpa_t gpa = vcpu->mmu.gva_to_gpa(vcpu, addr); > + u64 value; > + > + if (gpa == UNMAPPED_GVA) > + return -EFAULT; > + if (size == 1) { > + if (!emulator_write_phys(vcpu, gpa, &a0, sizeof(a0))) > + return -EFAULT; > + } else if (size == 2) { > + value = (u64)a1 << 32 | a0; > + if (!emulator_write_phys(vcpu, gpa, &value, sizeof(value))) > + return -EFAULT; > + } else > + return -E2BIG; > + > + return 0; > +} Hypercalls should return kvm-specific error codes (defined in include/linux/kvm_para.h), not Linux error codes, as they could be used in operating systems which have different values for E2BIG and friends. > +static void kvm_pte_clear(struct mm_struct *mm, > + unsigned long addr, pte_t *ptep) > +{ > + pte_t pte = {0}; > Surely there's a nice macro for creating a pte from an int? Any performance measurement? -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/