From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/5] KVM: Add paravirt MMU write support Date: Mon, 18 Jun 2007 15:38:41 +0300 Message-ID: <46767CD1.7030208@qumranet.com> References: <4675F462.1010708@codemonkey.ws> <4675F533.40809@codemonkey.ws> <46764061.9080705@qumranet.com> <46767B8C.9050001@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <46767B8C.9050001-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Anthony Liguori Cc: kvm-devel , virtualization List-Id: virtualization@lists.linuxfoundation.org Anthony Liguori wrote: >> >> Hypercalls should return kvm-specific error codes (defined in >> include/linux/kvm_para.h), not Linux error codes, as they could be >> used in operating systems which have different values for E2BIG and >> friends. > > If Linux's errnos are stable, we could just use them and let a > non-Linux guest define a set of KVM_E2BIG, etc.? It just seemed > pretty ugly to add a bunch of these. The ugliness will serve to remind us that this is a potentially non-Linux path. In this particular case, the names are not present in guest-visible headers, but any other that is made visible must have a non-Linux-dependent name, so I don't see why error numbers should be treated specially. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/