virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: john stultz <johnstul@us.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	virtualization <virtualization@lists.linux-foundation.org>,
	Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH 2/2] lguest: handle dodgy/non-existent TSC. Guest code.
Date: Thu, 05 Jul 2007 10:56:23 -0700	[thread overview]
Message-ID: <468D30C7.7050103@goop.org> (raw)
In-Reply-To: <1183536605.6005.19.camel@localhost.localdomain>

Rusty Russell wrote:
> 	Yes, but jiffies is the lowest-rated clock (so PIT will get chosen).  I
> initially mugged clocksource_jiffies.rating, but that felt wrong: it's
> currently not registered when this code runs so it's a simple
> assignment, but if code order was to change it would have to be a call
> to clocksource_change_rating().
>
> There's an internal clocksource_override which I could use, but I'd have
> to make it non-static.
>
> Maybe John has thoughts?

How about having lguest_tsc and lguest_jiffies clocksources, with the 
approprate ratings to get them selected when needed?  And lguest_jiffies 
could probably just be a new structure which points to the normal 
jiffies clocksource function(s).

    J

  parent reply	other threads:[~2007-07-05 17:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-04  6:19 [PATCH 1/2] lguest: handle dodgy/non-existent TSC. Host code Rusty Russell
2007-07-04  6:20 ` [PATCH 2/2] lguest: handle dodgy/non-existent TSC. Guest code Rusty Russell
2007-07-04  6:44   ` Tony Breeds
2007-07-04  8:10     ` Rusty Russell
2007-07-05 15:37       ` john stultz
2007-07-05 17:56       ` Jeremy Fitzhardinge [this message]
2007-07-04 13:20 ` [PATCH 1/2] lguest: handle dodgy/non-existent TSC. Host code Matt Mackall
2007-07-05  1:38   ` Rusty Russell
2007-07-05  6:41     ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468D30C7.7050103@goop.org \
    --to=jeremy@goop.org \
    --cc=akpm@linux-foundation.org \
    --cc=johnstul@us.ibm.com \
    --cc=mpm@selenic.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).