From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Chris Wright <chrisw@sous-sol.org>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization@lists.osdl.org,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
"Robert P. J. Day" <rpjday@mindspring.com>
Subject: Re: [PATCH] VMI: remove CONFIG_DEBUG_PAGE_TYPE and associated bitrotted code
Date: Fri, 06 Jul 2007 13:28:16 -0700 [thread overview]
Message-ID: <468EA5E0.4070501@goop.org> (raw)
In-Reply-To: <468EA27C.9060401@vmware.com>
Zachary Amsden wrote:
> I'd rather keep it, even with bitrot - it was non-trivial to get
> correct, and found many surprises in the code; most notably, it can
> detect
>
> 1) PTE writes to pages not declared as page tables
> 2) Failure to allocate or de-allocate page tables using the
> paravirt-ops API
> 3) PTE writes using the wrong level operations
>
> These are most useful properties; in fact, I would like to extend the
> code for 64-bit paravirt-ops and 4-level paging, so rather not kill it
> until then.
>
> I never merged the whole bit upstream because it added a field to
> struct page.
Hm, is that a big problem? It would be OK for a debug config option,
wouldn't it? Also, it doesn't seem particularly vmi-specific. Could it
be made part of the pvops infrastructure?
J
next prev parent reply other threads:[~2007-07-06 20:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0707060847470.23786@localhost.localdomain>
2007-07-06 18:25 ` [PATCH] I386: Deactivate the test for the dead CONFIG_DEBUG_PAGE_TYPE variable Stefan Richter
2007-07-06 19:54 ` Zachary Amsden
2007-07-06 20:16 ` [PATCH] VMI: remove CONFIG_DEBUG_PAGE_TYPE and associated bitrotted code Chris Wright
2007-07-06 20:13 ` Zachary Amsden
2007-07-06 20:28 ` Jeremy Fitzhardinge [this message]
2007-07-06 20:34 ` Zachary Amsden
2007-07-06 21:01 ` Jeremy Fitzhardinge
2007-07-06 21:17 ` Zachary Amsden
2007-07-06 20:40 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468EA5E0.4070501@goop.org \
--to=jeremy@goop.org \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).