Re: [PATCH RFC] first cut at splitting up paravirt_ops

[Zachary Amsden <zach@vmware.com>]

Jeremy Fitzhardinge wrote:
> Here's a first attempt at splitting up paravirt_ops into more specific 
> chunks.  Its pretty clunky and chunky; mostly just a lot of 
> replacement.  The grouping of ops is very first cut; I'm open to 
> suggestions about what groups should exist and what ops they each 
> should contain.
>

Well, I think they are pretty good, but for the init group of ops, it 
seems it would be clearer conceptually to group pagetable setup with the 
MMU hooks and time init with the time operations.  Otherwise, the init 
group gets very jumbled as we pull in new interfaces (APIC has BSP and 
AP init functions, for example).


> The only slightly subtle part is that I've kept the structures wrapped 
> in a paravirt_ops structure, primarily so that we can still use 
> offsetof for generating patching IDs.  The paravirt_ops is static, and 
> I extract the sub-groups with global aliases which can be individually 
> exported.

I think that is probably the best solution; splitting the patch code to 
deal with individual structure seems awkward.

Zach