From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Chris Wright <chrisw@sous-sol.org>,
Virtualization Mailing List <virtualization@lists.osdl.org>
Subject: Re: [PATCH RFC] first cut at splitting up paravirt_ops
Date: Mon, 09 Jul 2007 23:40:49 -0700 [thread overview]
Message-ID: <469329F1.4080505@goop.org> (raw)
In-Reply-To: <4692D871.60002@vmware.com>
Zachary Amsden wrote:
> Well, I think they are pretty good, but for the init group of ops, it
> seems it would be clearer conceptually to group pagetable setup with
> the MMU hooks and time init with the time operations. Otherwise, the
> init group gets very jumbled as we pull in new interfaces (APIC has
> BSP and AP init functions, for example).
I tend to agree, but the main reason I grouped them is because they're
init code, and therefore need never be exported. Also, some are really
just used at boot time, and don't clearly fit into any other grouping.
I guess I could expand pv_misc_ops.
> I think that is probably the best solution; splitting the patch code
> to deal with individual structure seems awkward.
Yes.
The only downside is that moving an op between groups requires quite a
few places to be touched. At least its all compile-time checked.
J
prev parent reply other threads:[~2007-07-10 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 0:19 [PATCH RFC] first cut at splitting up paravirt_ops Jeremy Fitzhardinge
2007-07-10 0:53 ` Zachary Amsden
2007-07-10 6:40 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469329F1.4080505@goop.org \
--to=jeremy@goop.org \
--cc=chrisw@sous-sol.org \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).