From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add I/O hypercalls for i386 paravirt Date: Wed, 22 Aug 2007 15:09:10 +0300 Message-ID: <46CC2766.7020602@qumranet.com> References: <46CBC842.4070100@vmware.com> <46CBCADF.2070400@qumranet.com> <1187763956.6174.48.camel@localhost.localdomain> <20070822103545.GG2642@bingen.suse.de> <46CC0719.2080103@qumranet.com> <20070822110810.GO32640@bingen.suse.de> <46CC0EAF.3000805@qumranet.com> <20070822112352.GQ32640@bingen.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070822112352.GQ32640@bingen.suse.de> Sender: linux-kernel-owner@vger.kernel.org To: Andi Kleen Cc: Rusty Russell , Andrew Morton , Linux Kernel Mailing List , Chris Wright , Virtualization Mailing List List-Id: virtualization@lists.linuxfoundation.org Andi Kleen wrote: > On Wed, Aug 22, 2007 at 01:23:43PM +0300, Avi Kivity wrote: > >> Andi Kleen wrote: >> >>>> I don't see why it's intrusive -- they all use the APIs, right? >>>> >>>> >>> Yes, but it still changes them. It might have a larger impact >>> on code size for example. >>> >>> >> Only if CONFIG_PARAVIRT is defined. >> > > Which eventually distribution kernels will do. > > >> And even then, all the performance >> sensitive stuff uses mmio, no? >> > > Not worried about performance, but just impact on code size etc. > Ah. But that's mostly modules, so real in-core changes should be very small (say 10 bytes per call site X 10 callsites per driver X 10 drivers... even if off by an order of magnitude it's still tiny) -- error compiling committee.c: too many arguments to function