From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH RFC REPOST 1/2] paravirt: refactor struct paravirt_ops into smaller pv_*_ops
Date: Fri, 12 Oct 2007 12:16:04 -0700 [thread overview]
Message-ID: <470FC7F4.1030300@goop.org> (raw)
In-Reply-To: <200710120001.52456.rusty@rustcorp.com.au>
Rusty Russell wrote:
> Sure, but this can actually be a temporary thing inside the patch code (or at
> least static to that file if it's too big for the stack).
>
> struct paravirt_ops patch_template = { .pv_info = pv_info, .pv_cpu_ops =
> pv_cpu_ops, ... };
>
> Then you can even rename struct paravirt_ops to "struct patch_template" and
> we're well on the way to making this a generic function-call patching
> mechanism, rather than something paravirt-specific.
>
Hm, I see. I'm not quite sure that's the best way to achieve a generic
result, but I see your point.
> Hope that clarifies my thinking...
Well, I'd agree with making the code more generic if another user
appears, but I'd rather not do it prematurely.
Sorry, I forgot to update lguest. I'll do that and repost (but I won't
have had a chance to test it).
Are you otherwise happy with the patch in its current form? And are you
happy with the lazymode changes?
J
next prev parent reply other threads:[~2007-10-12 19:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 18:24 [PATCH RFC REPOST 1/2] paravirt: refactor struct paravirt_ops into smaller pv_*_ops Jeremy Fitzhardinge
2007-10-10 6:35 ` Rusty Russell
2007-10-10 17:48 ` Jeremy Fitzhardinge
2007-10-10 18:02 ` Jeremy Fitzhardinge
2007-10-11 14:01 ` Rusty Russell
2007-10-12 19:16 ` Jeremy Fitzhardinge [this message]
2007-10-15 8:16 ` Rusty Russell
2007-10-15 19:23 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470FC7F4.1030300@goop.org \
--to=jeremy@goop.org \
--cc=anthony@codemonkey.ws \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).