From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: ehabkost@redhat.com, linux-kernel@vger.kernel.org,
Glauber de Oliveira Costa <gcosta@redhat.com>,
chrisw@sous-sol.org, anthony@codemonkey.ws,
akpm@linux-foundation.org,
virtualization@lists.linux-foundation.org, tglx@linutronix.de,
roland@redhat.com, ak@suse.de
Subject: Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
Date: Thu, 13 Dec 2007 13:26:29 -0800 [thread overview]
Message-ID: <4761A385.1080301@zytor.com> (raw)
In-Reply-To: <20071213212221.GA16747@elte.hu>
Ingo Molnar wrote:
>
>> could we _please_ use basic tools as vmlinux size comparison and
>> objcompare when unifying, to make sure it's a 100% identity
>> conversion?
>
> case in point, the patch claims:
>
>>> No functional change is made.
>
> but vmlinux before/after size comparison shows:
>
> text data bss dec hex filename
> 8802894 1224910 3526656 13554460 ced31c vmlinux.before
> 8803042 1224910 3526656 13554608 ced3b0 vmlinux.after
>
Well, "no functional changes" is not quite the same thing as "no object
code changes".
-hpa
next prev parent reply other threads:[~2007-12-13 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11975561713425-git-send-email-gcosta@redhat.com>
2007-12-13 20:28 ` [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss Ingo Molnar
[not found] ` <20071213202800.GD25130@elte.hu>
2007-12-13 20:58 ` Ingo Molnar
2007-12-13 21:22 ` Ingo Molnar
[not found] ` <20071213212221.GA16747@elte.hu>
2007-12-13 21:26 ` H. Peter Anvin [this message]
2007-12-13 21:35 ` Ingo Molnar
2007-12-13 21:37 ` Tom Spink
[not found] ` <7b9198260712131337j6249c980q55306b676b361776@mail.gmail.com>
2007-12-13 21:40 ` Glauber de Oliveira Costa
[not found] ` <20071213213517.GA25563@elte.hu>
2007-12-13 21:40 ` H. Peter Anvin
2007-12-13 21:51 ` Glauber de Oliveira Costa
2007-12-13 19:25 Glauber de Oliveira Costa
2007-12-14 10:43 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2007-12-13 14:29 Glauber de Oliveira Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4761A385.1080301@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anthony@codemonkey.ws \
--cc=chrisw@sous-sol.org \
--cc=ehabkost@redhat.com \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).