Re: [PATCH] Fix compile warnings in virtio_balloon

[Anthony Liguori <aliguori@us.ibm.com>]

Rusty Russell wrote:
> On Friday 25 January 2008 07:03:18 Anthony Liguori wrote:
>   
>> On x86_64, min was throwing a warning.  ARRAY_SIZE is unsigned long so
>> let's switch to using that for num.
>>     
>
> Creates warning on 32-bit.
>
> How about this?
>   
Yeah, that's fine.

Regards,

Anthony Liguori
> ===
>
> On x86_64, min was throwing a warning.  size_t is correct for 32 and 64.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -82,7 +82,7 @@ static void tell_host(struct virtio_ball
>  	wait_for_completion(&vb->acked);
>  }
>
> -static void fill_balloon(struct virtio_balloon *vb, unsigned int num)
> +static void fill_balloon(struct virtio_balloon *vb, size_t num)
>  {
>  	/* We can only do one array worth at a time. */
>  	num = min(num, ARRAY_SIZE(vb->pfns));
> @@ -92,7 +92,7 @@ static void fill_balloon(struct virtio_b
>  		if (!page) {
>  			if (printk_ratelimit())
>  				dev_printk(KERN_INFO, &vb->vdev->dev,
> -					   "Out of puff! Can't get %u pages\n",
> +					   "Out of puff! Can't get %zu pages\n",
>  					   num);
>  			/* Sleep for at least 1/5 of a second before retry. */
>  			msleep(200);
> @@ -121,7 +121,7 @@ static void release_pages_by_pfn(const u
>  	}
>  }
>
> -static void leak_balloon(struct virtio_balloon *vb, unsigned int num)
> +static void leak_balloon(struct virtio_balloon *vb, size_t num)
>  {
>  	struct page *page;
>
>