From: Avi Kivity <avi@qumranet.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] Use PCI revision field to indicate virtio PCI ABI version
Date: Tue, 29 Jan 2008 10:03:26 +0200 [thread overview]
Message-ID: <479EDDCE.8000000@qumranet.com> (raw)
In-Reply-To: <200801291421.00278.rusty@rustcorp.com.au>
Rusty Russell wrote:
> On Tuesday 29 January 2008 02:59:59 Anthony Liguori wrote:
>
>> As Avi pointed out, as we continue to massage the virtio PCI ABI, we can
>> make things a little more friendly to users by utilizing the PCI revision
>> field to indicate which version of the ABI we're using. This is a hard ABI
>> version and incrementing it will cause the guest driver to break.
>>
>> This is the necessary changes to virtio_pci to support this.
>>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>
>
> Applied, thanks.
>
>
But that's done at the wrong level. Anthony agreed the revision ID
should indicate the device ABI, not just the virtio ABI. If we move to
that level, bumping just one device rev id on the host will break all
devices on the guest.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-01-29 8:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 15:59 [PATCH] Use PCI revision field to indicate virtio PCI ABI version Anthony Liguori
2008-01-29 3:20 ` Rusty Russell
2008-01-29 8:03 ` Avi Kivity [this message]
2008-01-29 12:38 ` Rusty Russell
2008-01-29 16:03 ` Anthony Liguori
2008-01-30 11:10 ` Rusty Russell
2008-01-29 14:16 ` Anthony Liguori
2008-01-29 14:29 ` Christian Borntraeger
2008-01-29 14:42 ` Avi Kivity
2008-01-29 14:56 ` Anthony Liguori
2008-01-29 15:32 ` Avi Kivity
2008-01-29 15:39 ` Christian Borntraeger
2008-01-29 16:02 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479EDDCE.8000000@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).