From: Chris Lalancette <clalance@redhat.com>
To: virtualization@lists.linux-foundation.org
Cc: kvm@vger.kernel.org
Subject: [Fwd: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe]
Date: Wed, 21 May 2008 15:12:39 +0200 [thread overview]
Message-ID: <48341FC7.4060600@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 49 bytes --]
(sent to the kvm mailing list erroneously first)
[-- Attachment #2: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe.eml --]
[-- Type: message/rfc822, Size: 4125 bytes --]
[-- Attachment #2.1.1: Type: text/plain, Size: 209 bytes --]
Fix a modprobe virtio_blk ; rmmod virtio_blk ; modprobe virtio_blk crash; this
was basically because we weren't doing "del_gendisk()" in the remove path.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
[-- Attachment #2.1.2: virtio-blk-rmmod-crash.patch --]
[-- Type: text/x-patch, Size: 734 bytes --]
commit 9ae82ccb26be0155ad81b2630090e85639a0dc56
Author: Chris Lalancette <clalance@redhat.com>
Date: Fri May 16 15:31:06 2008 -0400
Fix a modprobe virtio_blk ; rmmod virtio_blk ; modprobe virtio_blk crash;
this was basically because we weren't doing "del_gendisk()" in the remove
path.
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 4962e62..c678ac5 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -294,6 +294,7 @@ static void virtblk_remove(struct virtio_device *vdev)
vdev->config->reset(vdev);
blk_cleanup_queue(vblk->disk->queue);
+ del_gendisk(vblk->disk);
put_disk(vblk->disk);
unregister_blkdev(major, "virtblk");
mempool_destroy(vblk->pool);
[-- Attachment #3: Type: text/plain, Size: 184 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization
next reply other threads:[~2008-05-21 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 13:12 Chris Lalancette [this message]
2008-05-22 11:33 ` [Fwd: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe] Rusty Russell
[not found] ` <200805222133.01686.rusty@rustcorp.com.au>
2008-05-22 11:35 ` Jens Axboe
[not found] ` <20080522113517.GC7712@kernel.dk>
2008-05-22 12:03 ` Chris Lalancette
[not found] ` <483560FB.4040500@redhat.com>
2008-05-22 12:07 ` Jens Axboe
2008-05-23 1:16 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48341FC7.4060600@redhat.com \
--to=clalance@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).