From: Avi Kivity <avi@qumranet.com>
To: Ben-Ami Yassour <benami@il.ibm.com>
Cc: Amit Shah <amit.shah@qumranet.com>,
kvm@vger.kernel.org, Muli Ben-Yehuda <muli@il.ibm.com>,
allen.m.kay@intel.com, chrisw@redhat.com, weidong.han@intel.com,
virtualization@lists.osdl.org
Subject: Re: [PATCH 2/4] KVM: Introduce a callback routine for IOAPIC ack handling
Date: Thu, 10 Jul 2008 16:57:44 +0300 [thread overview]
Message-ID: <48761558.3070703@qumranet.com> (raw)
In-Reply-To: <1215513283.31546.133.camel@cluwyn.haifa.ibm.com>
Ben-Ami Yassour wrote:
> On Mon, 2008-07-07 at 13:08 +0300, Avi Kivity wrote:
>
>> Amit Shah wrote:
>>
>>> This will be useful for acking irqs of assigned devices
>>>
>>>
>>>
>> And also for improving time drift tracking.
>>
>> Please make this more generic by having a list of callbacks. There
>> could also be just one list, rather than one for the ioapic and one for
>> the pic as implemented now.
>>
>> It may also make sense to filter the irq number before calling the
>> callback rather than relying on the callback to ignore uninteresting irqs.
>>
>>
> Avi,
>
> Did you mean something like the patch below?
>
I did, and have something very similar queued.
> How should we protect list accesses, should it be a new lock or an existing one?
>
>
kvm->lock for now.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-07-10 13:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 12:55 PCI device assignment to guests Amit Shah
2008-06-27 12:55 ` [PATCH 1/4] KVM: Introduce kvm_set_irq to inject interrupts in guests Amit Shah
2008-06-27 12:55 ` [PATCH 2/4] KVM: Introduce a callback routine for IOAPIC ack handling Amit Shah
2008-06-27 12:55 ` [PATCH 3/4] KVM: Introduce a callback routine for PIC " Amit Shah
2008-06-27 12:55 ` [PATCH 4/4] KVM: Handle device assignment to guests Amit Shah
2008-07-02 10:25 ` Amit Shah
2008-07-07 10:08 ` [PATCH 2/4] KVM: Introduce a callback routine for IOAPIC ack handling Avi Kivity
2008-07-08 10:34 ` Ben-Ami Yassour
2008-07-10 13:57 ` Avi Kivity [this message]
2008-07-17 16:56 ` Ben-Ami Yassour
2008-07-17 17:16 ` Avi Kivity
2008-07-17 17:25 ` Avi Kivity
2008-07-05 11:05 ` [PATCH 1/4] KVM: Introduce kvm_set_irq to inject interrupts in guests Avi Kivity
2008-07-06 13:50 ` Ben-Ami Yassour
2008-07-06 13:59 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48761558.3070703@qumranet.com \
--to=avi@qumranet.com \
--cc=allen.m.kay@intel.com \
--cc=amit.shah@qumranet.com \
--cc=benami@il.ibm.com \
--cc=chrisw@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=virtualization@lists.osdl.org \
--cc=weidong.han@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).