virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: virtualization@lists.osdl.org, xen-devel@lists.xensource.com
Cc: Chris Wright <chrisw@sous-sol.org>
Subject: [patch xen.git xen-tip/master] xen: fix xenbus frontend build
Date: Tue, 05 May 2009 11:42:00 -0700	[thread overview]
Message-ID: <4A008878.7030409@oracle.com> (raw)

From: Randy Dunlap <randy.dunlap@oracle.com>

When a driver kconfig symbol =m and it selects another symbol,
that other symbol will also be =m (unless something else
causes it to be =y), so when XEN_BLKDEV_FRONTEND=m and/or
XEN_NETDEV_FRONTEND=m, then XEN_XENBUS_FRONTEND=m, but that
won't build (build error message below).  Changing
XEN_XENBUS_FRONTEND from a tristate to a bool makes it be
=y (builtin) any time that it is selected, so there is
no build error.

arch/x86/pci/built-in.o: In function `xenbus_register_frontend':
include/xen/xenbus.h:115: undefined reference to `__xenbus_register_frontend'

OTOH, I could have goofed my git trees somehow...

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-xyz.orig/drivers/xen/Kconfig
+++ linux-xyz/drivers/xen/Kconfig
@@ -85,7 +85,7 @@ config XEN_SYS_HYPERVISOR
 	 but will have no xen contents.
 
 config XEN_XENBUS_FRONTEND
-       tristate
+       bool
 
 config XEN_GNTDEV
 	bool "userspace grant access device driver"

             reply	other threads:[~2009-05-05 18:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05 18:42 Randy Dunlap [this message]
2009-05-06 22:38 ` [patch xen.git xen-tip/master] xen: fix xenbus frontend build M A Young
2009-05-06 22:48   ` Jeremy Fitzhardinge
2009-05-07  2:20   ` [Xen-devel] " Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A008878.7030409@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=chrisw@sous-sol.org \
    --cc=virtualization@lists.osdl.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).