From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: xen-devel@lists.xensource.com, jeremy@xensource.com,
the arch/x86 maintainers <x86@kernel.org>,
linux-kernel@vger.kernel.org, chrisw@sous-sol.org,
virtualization@lists.osdl.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 1/1] XEN: enlighten, use uninitialized_var(cx)
Date: Tue, 25 Aug 2009 15:29:50 -0700 [thread overview]
Message-ID: <4A9465DE.2030709@goop.org> (raw)
In-Reply-To: <1251234044-6943-1-git-send-email-jirislaby@gmail.com>
On 08/25/09 14:00, Jiri Slaby wrote:
> To avoid a wrong compiler warning, use unitialized_var(cx) in
> xen_init_cpuid_mask.
>
> cx needn't be initialized for cpuid when ax is 1.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Jeremy Fitzhardinge <jeremy@xensource.com>
> Cc: Chris Wright <chrisw@sous-sol.org>
>
Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> ---
> arch/x86/xen/enlighten.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index e90540a..5ab75e2 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -202,7 +202,7 @@ static void xen_cpuid(unsigned int *ax, unsigned int *bx,
>
> static __init void xen_init_cpuid_mask(void)
> {
> - unsigned int ax, bx, cx, dx;
> + unsigned int ax, bx, uninitialized_var(cx), dx;
>
> cpuid_leaf1_edx_mask =
> ~((1 << X86_FEATURE_MCE) | /* disable MCE */
>
next prev parent reply other threads:[~2009-08-25 22:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 21:00 [PATCH 1/1] XEN: enlighten, use uninitialized_var(cx) Jiri Slaby
2009-08-25 22:29 ` Jeremy Fitzhardinge [this message]
2009-08-26 6:09 ` Ingo Molnar
2009-08-26 17:27 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9465DE.2030709@goop.org \
--to=jeremy@goop.org \
--cc=chrisw@sous-sol.org \
--cc=jeremy@xensource.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=virtualization@lists.osdl.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).