From: john cooper <john.cooper@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: john.cooper@redhat.com,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.
Date: Wed, 07 Oct 2009 01:48:29 -0400 [thread overview]
Message-ID: <4ACC2BAD.8010901@redhat.com> (raw)
In-Reply-To: <200910061951.47231.rusty@rustcorp.com.au>
Rusty Russell wrote:
> Also, I've been convinced to just hand over the 20 byte serial number
> since we're revisiting this. It's simple, and there's no clear consensus.
I'm fine with this approach as it is where
I originally started with this Sisyphus Patch.
My bias toward pressing the ATA identify
interface into service here was just to reuse
an existing interface and make life easier
from the perspective of the guest.
On the subject of retrieving the S/N alone, this
is the form of the simplistic ioctl originally
used to do so:
unsigned char sn[80];
:
sn[0] = sizeof(sn);
ioctl(fd, VBLK_GET_SN, &sn);
-john
--
john.cooper@redhat.com
next prev parent reply other threads:[~2009-10-07 5:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200909300248.09630.rusty@rustcorp.com.au>
2009-09-30 7:41 ` [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field Christian Borntraeger
2009-10-05 16:20 ` john cooper
[not found] ` <4ACA1CBC.8020402@redhat.com>
2009-10-06 9:21 ` Rusty Russell
2009-10-07 5:48 ` john cooper [this message]
2009-09-29 17:18 Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACC2BAD.8010901@redhat.com \
--to=john.cooper@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).