From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 7/7] virtio: console: Return -EPIPE if port on the host isn't connected Date: Tue, 23 Mar 2010 12:15:19 +0100 Message-ID: <4BA8A2C7.4070908@redhat.com> References: <1269334680-1369-4-git-send-email-amit.shah@redhat.com> <1269334680-1369-5-git-send-email-amit.shah@redhat.com> <1269334680-1369-6-git-send-email-amit.shah@redhat.com> <1269334680-1369-7-git-send-email-amit.shah@redhat.com> <1269334680-1369-8-git-send-email-amit.shah@redhat.com> <20100323090023.GD22774@redhat.com> <20100323091352.GI8675@amit-x200.redhat.com> <4BA89C1E.7090403@redhat.com> <20100323105220.GK8675@amit-x200.redhat.com> <4BA8A03C.8030002@redhat.com> <20100323110957.GB3080@amit-x200.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100323110957.GB3080@amit-x200.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Amit Shah Cc: virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" List-Id: virtualization@lists.linuxfoundation.org On 03/23/10 12:09, Amit Shah wrote: > I didn't really look at blocking / non-blocking support in write() > because of the cpu_relax(), which will always block the app. Right, the spinning again ... When we kill this we really must care to implement blocking + non-blocking + poll + partial writes correctly. cheers, Gerd