From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH for-2.6.35] virtio-pci: disable msi at startup Date: Wed, 23 Jun 2010 16:59:11 +0300 Message-ID: <4C22132F.4060307@redhat.com> References: <20100610152252.GA3510@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100610152252.GA3510@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: Anthony Liguori , linux-pci@vger.kernel.org, Matt Carlson , linux-kernel@vger.kernel.org, Jesse Barnes , virtualization@lists.linux-foundation.org, "Rafael J. Wysocki" , Kenji Kaneshige , Tejun Heo , "David S. Miller" , Bjorn Helgaas List-Id: virtualization@lists.linuxfoundation.org On 06/10/2010 06:22 PM, Michael S. Tsirkin wrote: > virtio-pci resets the device at startup by writing to the status > register, but this does not clear the pci config space, > specifically msi enable status which affects register > layout. > > This breaks things like kdump when they try to use e.g. virtio-blk. > > Fix by forcing msi off at startup. Since pci.c already has > a routine to do this, we export and use it instead of duplicating code. > > Why doesn't a device reset result in msi being cleared? Shouldn't a reset be equivalent to power cycling? -- error compiling committee.c: too many arguments to function