virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	linux-pci@vger.kernel.org, Matt Carlson <mcarlson@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	virtualization@lists.linux-foundation.org,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	Tejun Heo <tj@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH for-2.6.35] virtio-pci: disable msi at startup
Date: Wed, 23 Jun 2010 17:21:37 +0300	[thread overview]
Message-ID: <4C221871.6020509@redhat.com> (raw)
In-Reply-To: <20100623135946.GA30526@redhat.com>

On 06/23/2010 04:59 PM, Michael S. Tsirkin wrote:
>
>> Why doesn't a device reset result in msi being cleared?
>>      
> This is not a standard function reset. This is virtio specific
> command. So it only clears virtio registers.
>    

I see.  We should implement FLR in qemu.  If we don't already do so, we 
should probably FLR anything that moves when a kexec kernel starts.

>> Shouldn't a reset be equivalent to power cycling?
>>      
> If we did this, driver would need to restore registers
> such as BAR etc.
>    

We could save/restore the registers we care about.

-- 
error compiling committee.c: too many arguments to function

  parent reply	other threads:[~2010-06-23 14:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100610152252.GA3510@redhat.com>
2010-06-10 15:34 ` [PATCH for-2.6.35] virtio-pci: disable msi at startup Jesse Barnes
2010-06-23 13:59 ` Avi Kivity
2010-06-23 13:59   ` Michael S. Tsirkin
     [not found]   ` <20100623135946.GA30526@redhat.com>
2010-06-23 14:21     ` Avi Kivity [this message]
2010-06-23 14:43       ` Michael S. Tsirkin
     [not found]       ` <20100623144307.GB30526@redhat.com>
2010-06-23 15:15         ` Avi Kivity
     [not found]         ` <4C222508.2060804@redhat.com>
2010-06-23 15:26           ` Michael S. Tsirkin
     [not found]           ` <20100623152633.GC30526@redhat.com>
2010-06-23 15:35             ` Avi Kivity
     [not found]             ` <4C2229DB.6060706@redhat.com>
2010-06-23 15:43               ` Michael S. Tsirkin
2010-06-23 15:51               ` Jesse Barnes
     [not found]               ` <20100623154311.GD30526@redhat.com>
2010-06-23 15:53                 ` Avi Kivity
2010-06-10 15:22 Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C221871.6020509@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=davem@davemloft.net \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mcarlson@broadcom.com \
    --cc=mst@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=tj@kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).