From: Hank Janssen <hjanssen@sailtheuniverse.com>
To: Joe Perches <joe@perches.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, virtualization@lists.osdl.org,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH 2/5] staging: hv: Fixed lockup problem with bounce_buffer scatter list - RESEND
Date: Tue, 31 Aug 2010 13:03:39 -0700 [thread overview]
Message-ID: <4C7D601B.3060708@sailtheuniverse.com> (raw)
In-Reply-To: <1283359091.1797.179.camel@Joe-Laptop>
On 09/01/2010 09:38 AM, Joe Perches wrote:
> On Tue, 2010-08-31 at 11:13 -0700, Hank Janssen wrote:
>
>> diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
> []
>> - request->DataBuffer.PfnArray[i] =
>> - page_to_pfn(sg_page((&sgl[i])));
>> + request->DataBuffer.PfnArray[i] =
>> + page_to_pfn(sg_page((&sgl[i])));
>
> I did a bit of a doubletake reading this last change.
>
> This isn't actually a part of your fix and it introduces
> a whitespace error.
>
I will resubmit this patch and clean up the whitespace error.
When change the code I normally also change the indentation to the
correct format for that area of the code. That is how the whitespace
snuck in there.
Thanks,
Hank.
next prev parent reply other threads:[~2010-08-31 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 18:13 [PATCH 2/5] staging: hv: Fixed lockup problem with bounce_buffer scatter list - RESEND Hank Janssen
2010-09-01 16:38 ` Joe Perches
2010-08-31 20:03 ` Hank Janssen [this message]
2010-09-01 22:45 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7D601B.3060708@sailtheuniverse.com \
--to=hjanssen@sailtheuniverse.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).