virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Raghavendra K T <raghukt@linux.vnet.ibm.com>
Cc: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
	KVM <kvm@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
	Dave Jiang <dave.jiang@intel.com>,
	x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Xen <xen-devel@lists.xensource.com>,
	Sedat Dilek <sedat.dilek@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Virtualization <virtualization@lists.linux-foundation.org>,
	Yinghai Lu <yinghai@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Suzuki Poulose <suzuki@linux.vnet.ibm.com>
Subject: Re: [PATCH RFC V2 3/5] kvm hypervisor : Add two hypercalls to support pv-ticketlock
Date: Thu, 27 Oct 2011 12:17:15 +0200	[thread overview]
Message-ID: <4EA92FAB.1050607@redhat.com> (raw)
In-Reply-To: <4EA85A9D.5060203@linux.vnet.ibm.com>

On 10/26/2011 09:08 PM, Raghavendra K T wrote:
> On 10/26/2011 04:04 PM, Avi Kivity wrote:
>> On 10/25/2011 08:24 PM, Raghavendra K T wrote:
> CCing Ryan also
>>>
>>> So then do also you foresee the need for directed yield at some point,
>>> to address LHP? provided we have good improvements to prove.
>>
>> Doesn't this patchset completely eliminate lock holder preemption?
>>
> Basically I was curious whether we can do more better with your
> directed yield discussions in https://lkml.org/lkml/2010/8/2/106 .
>
> I felt we can get little more improvement with doing directed yield to
> lock-holder in case of LHP than sleeping. But I may be wrong.
>
> So wanted to get the feedback, on whether I am thinking in right
> direction.

i guess donating some time to the lock holder could help, but not by
much. The problem with non-pv spinlocks is that you can't just sleep,
since no one will wake you up, so you have to actively boost the lock
holder.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

      parent reply	other threads:[~2011-10-27 10:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111023190307.16364.35381.sendpatchset@oc5400248562.ibm.com>
     [not found] ` <20111023190700.16364.7548.sendpatchset@oc5400248562.ibm.com>
2011-10-24 10:01   ` [PATCH RFC V2 4/5] kvm guest : Added configuration support to enable debug information for KVM Guests Sasha Levin
     [not found] ` <20111023190558.16364.2136.sendpatchset@oc5400248562.ibm.com>
2011-10-24 10:01   ` [PATCH RFC V2 3/5] kvm hypervisor : Add two hypercalls to support pv-ticketlock Sasha Levin
     [not found]   ` <4EA53A7D.300@redhat.com>
     [not found]     ` <20111024122734.GA10634@linux.vnet.ibm.com>
     [not found]       ` <4EA56385.9040302@redhat.com>
     [not found]         ` <20111024135032.GB10634@linux.vnet.ibm.com>
     [not found]           ` <4EA6FEC2.1060209@linux.vnet.ibm.com>
     [not found]             ` <4EA7E21B.8020805@redhat.com>
     [not found]               ` <4EA85A9D.5060203@linux.vnet.ibm.com>
2011-10-27 10:17                 ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA92FAB.1050607@redhat.com \
    --to=avi@redhat.com \
    --cc=dave.jiang@intel.com \
    --cc=gregkh@suse.de \
    --cc=hpa@zytor.com \
    --cc=jeremy.fitzhardinge@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    --cc=raghukt@linux.vnet.ibm.com \
    --cc=riel@redhat.com \
    --cc=sedat.dilek@gmail.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=suzuki@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=vatsa@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).