From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors Date: Tue, 29 Nov 2011 16:58:23 +0200 Message-ID: <4ED4F30F.8000603@redhat.com> References: <1322559196-11139-1-git-send-email-levinsasha928@gmail.com> <20111129125622.GB19157@redhat.com> <1322573688.4395.11.camel@lappy> <20111129135406.GB30966@redhat.com> <1322576464.7003.6.camel@lappy> <20111129145451.GD30966@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111129145451.GD30966@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: markmc@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Sasha Levin List-Id: virtualization@lists.linuxfoundation.org On 11/29/2011 04:54 PM, Michael S. Tsirkin wrote: > > > > Which is actually strange, weren't indirect buffers introduced to make > > the performance *better*? From what I see it's pretty much the > > same/worse for virtio-blk. > > I know they were introduced to allow adding very large bufs. > See 9fa29b9df32ba4db055f3977933cd0c1b8fe67cd > Mark, you wrote the patch, could you tell us which workloads > benefit the most from indirect bufs? > Indirects are really for block devices with many spindles, since there the limiting factor is the number of requests in flight. Network interfaces are limited by bandwidth, it's better to increase the ring size and use direct buffers there (so the ring size more or less corresponds to the buffer size). -- error compiling committee.c: too many arguments to function