From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC V3 2/4] kvm hypervisor : Add a hypercall to KVM hypervisor to support pv-ticketlocks Date: Wed, 07 Dec 2011 16:52:53 +0200 Message-ID: <4EDF7DC5.5010504@redhat.com> References: <20111130085921.23386.89708.sendpatchset@oc5400248562.ibm.com> <20111130085959.23386.69166.sendpatchset@oc5400248562.ibm.com> <20111207104849.GA24849@amt.cnet> <4EDF5413.1030107@linux.vnet.ibm.com> <20111207123330.GA32212@amt.cnet> <4EDF6049.2030204@redhat.com> <20111207133947.GA1708@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111207133947.GA1708@amt.cnet> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Marcelo Tosatti Cc: Raghavendra K T , x86@kernel.org, Peter Zijlstra , Virtualization , "H. Peter Anvin" , Stefano Stabellini , Xen , Dave Jiang , KVM , Raghavendra K T , Ingo Molnar , Rik van Riel , Konrad Rzeszutek Wilk , Srivatsa Vaddagiri , Jeremy Fitzhardinge , Sasha Levin , Sedat Dilek , Thomas Gleixner , Yinghai Lu , Greg Kroah-Hartman , LKML , Dave Hansen , Suzuk List-Id: virtualization@lists.linuxfoundation.org On 12/07/2011 03:39 PM, Marcelo Tosatti wrote: > > Also I think we can keep the kicked flag in vcpu->requests, no need for > > new storage. > > Was going to suggest it but it violates the currently organized > processing of entries at the beginning of vcpu_enter_guest. > > That is, this "kicked" flag is different enough from vcpu->requests > processing that a separate variable seems worthwhile (even more > different with convertion to MP_STATE at KVM_GET_MP_STATE). IMO, it's similar to KVM_REQ_EVENT (which can also cause mpstate to change due to apic re-evaluation). -- error compiling committee.c: too many arguments to function