Linux virtualization list
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Santosh Jodh <Santosh.Jodh@citrix.com>, konrad@darnok.org
Cc: "jeremy@goop.org" <jeremy@goop.org>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"waldi@debian.org" <waldi@debian.org>,
	"joe.jin@oracle.com" <joe.jin@oracle.com>,
	"weiyi.huang@gmail.com" <weiyi.huang@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
	Paul Durrant <Paul.Durrant@citrix.com>,
	David Vrabel <david.vrabel@citrix.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	"lersek@redhat.com" <lersek@redhat.com>,
	dgdegra@ty
Subject: Re: [Xen-devel] [PATCH 0001/001] xen: multi page ring support for block devices
Date: Wed, 07 Mar 2012 09:33:26 +0000	[thread overview]
Message-ID: <4F5739760200007800076DA6@nat28.tlf.novell.com> (raw)
In-Reply-To: <CAPbh3rsExLtohBwVd_scYuO=GN1iZE5egQQ3x5M59YUno5Rtyw@mail.gmail.com>

>>> On 06.03.12 at 18:20, Konrad Rzeszutek Wilk <konrad@darnok.org> wrote:
>  -> the usage of XenbusStateInitWait? Why do we introduce that? Looks
> like a fix to something.

No, this is required to get the negotiation working (the frontend must
not try to read the new nodes until it can be certain that the backend
populated them). However, as already pointed out in an earlier reply
to Santosh, the way this is done here doesn't appear to allow for the
backend to already be in InitWait state when the frontend gets
invoked.

> -> XENBUS_MAX_RING_PAGES - why 2? Why not 4? What is the optimal
> default size for SSD usage? 16?

What do SSDs have to do with a XenBus definition? Imo it's wrong (and
unnecessary) to introduce a limit at the XenBus level at all - each driver
can do this for itself.

As to the limit for SSDs in the block interface - I don't think the number
of possibly simultaneous requests has anything to do with this. Instead,
I'd expect the request number/size/segments extension that NetBSD
apparently implements to possibly have an effect.

Jan

  reply	other threads:[~2012-03-07  9:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1330701099-18281-1-git-send-email-santoshprasadnayak@gmail.com>
2012-03-05 21:49 ` [PATCH 0001/001] xen: multi page ring support for block devices Santosh Jodh
     [not found] ` <7914B38A4445B34AA16EB9F1352942F1010A1FA12364@SJCPMAILBOX01.citrite.net>
2012-03-06  2:42   ` Rusty Russell
     [not found]   ` <87ty22xxee.fsf@rustcorp.com.au>
2012-03-06  6:21     ` Santosh Jodh
2012-03-06  8:34   ` Jan Beulich
2012-03-06 11:16   ` [Xen-devel] " Wei Liu
2012-03-06 17:20   ` Konrad Rzeszutek Wilk
2012-03-07  9:33     ` Jan Beulich [this message]
2012-03-07 15:15       ` Konrad Rzeszutek Wilk
2012-03-14  6:32       ` Justin Gibbs
2012-03-14  8:35         ` Jan Beulich
2012-03-14 15:34         ` Jan Beulich
2012-03-14 17:01           ` Justin Gibbs
2012-03-15  8:03             ` Jan Beulich
2012-03-15  8:51               ` Ian Campbell
2012-03-15  9:31                 ` Jan Beulich
     [not found]   ` <4F55DA3E0200007800076916@nat28.tlf.novell.com>
2012-03-14 17:17     ` Justin T. Gibbs
2012-03-15  8:09       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5739760200007800076DA6@nat28.tlf.novell.com \
    --to=jbeulich@suse.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=Santosh.Jodh@citrix.com \
    --cc=akpm@linux-foundation.org \
    --cc=david.vrabel@citrix.com \
    --cc=dgdegra@ty \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jeremy@goop.org \
    --cc=joe.jin@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=konrad@darnok.org \
    --cc=lersek@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=waldi@debian.org \
    --cc=weiyi.huang@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox