From: Paolo Bonzini <pbonzini@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm-devel <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Zhi Yong Wu <wuzhy@cn.ibm.com>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
lf-virt <virtualization@lists.linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 6/6] virtio-scsi: Set shost->max_id=1 for tcm_vhost WWPNs
Date: Thu, 05 Jul 2012 08:42:06 +0200 [thread overview]
Message-ID: <4FF5373E.8080703@redhat.com> (raw)
In-Reply-To: <1341453940.23954.229.camel@haakon2.linux-iscsi.org>
Il 05/07/2012 04:05, Nicholas A. Bellinger ha scritto:
>> > But that's what the config field is for... why can't tcm_vhost (or QEMU)
>> > set max_id to 0?
>> >
> So this patch was carried forward from Stefan's original code that I
> thought was required due to other limitations..
>
> If that's not the case anymore I'm happy to drop it for now and look
> into a proper fix outside of virtio-scsi.
>
I think max_id did not exist in the virtio-scsi configuration at the
time Stefan was working on it.
Paolo
next prev parent reply other threads:[~2012-07-05 6:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1341375846-27882-1-git-send-email-nab@linux-iscsi.org>
2012-07-04 4:24 ` [PATCH 1/6] vhost: Separate vhost-net features from vhost features Nicholas A. Bellinger
2012-07-04 4:41 ` Asias He
2012-07-04 4:24 ` [PATCH 2/6] vhost: make vhost work queue visible Nicholas A. Bellinger
2012-07-04 4:24 ` [PATCH 3/6] vhost: Add vhost_scsi specific defines Nicholas A. Bellinger
2012-07-04 4:24 ` [PATCH 4/6] tcm_vhost: Initial merge for vhost level target fabric driver Nicholas A. Bellinger
2012-07-04 4:24 ` [PATCH 5/6] virtio-scsi: Add vdrv->scan for post VIRTIO_CONFIG_S_DRIVER_OK LUN scanning Nicholas A. Bellinger
2012-07-04 4:24 ` [PATCH 6/6] virtio-scsi: Set shost->max_id=1 for tcm_vhost WWPNs Nicholas A. Bellinger
2012-07-04 14:02 ` [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6 Michael S. Tsirkin
2012-07-04 14:52 ` Paolo Bonzini
2012-07-04 15:05 ` Michael S. Tsirkin
2012-07-04 22:12 ` Anthony Liguori
2012-07-05 1:52 ` Nicholas A. Bellinger
2012-07-05 10:22 ` Paolo Bonzini
2012-07-05 13:53 ` Michael S. Tsirkin
2012-07-05 14:06 ` Anthony Liguori
2012-07-05 14:32 ` Paolo Bonzini
2012-07-05 21:00 ` Michael S. Tsirkin
[not found] ` <4FF59F6B.2000101@us.ibm.com>
2012-07-05 14:40 ` Michael S. Tsirkin
2012-07-05 14:47 ` Paolo Bonzini
2012-07-05 17:26 ` Michael S. Tsirkin
2012-07-06 3:01 ` Nicholas A. Bellinger
[not found] ` <1341543672.23954.285.camel@haakon2.linux-iscsi.org>
[not found] ` <1341553397.3023.16.camel@dabdike.hilton.com>
2012-07-06 9:13 ` SCSI Performance regression [was Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6] Nicholas A. Bellinger
[not found] ` <1341582550.2941.10.camel@dabdike>
2012-07-06 18:21 ` Nicholas A. Bellinger
2012-07-06 20:30 ` [Ksummit-2012-discuss] " Christoph Lameter
[not found] ` <alpine.DEB.2.00.1207061528520.2656@router.home>
2012-07-06 22:06 ` Nicholas A. Bellinger
2012-07-06 3:38 ` [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6 Nicholas A. Bellinger
2012-07-06 5:39 ` Paolo Bonzini
2012-07-05 17:53 ` Bart Van Assche
[not found] ` <4FF5D494.2090707@acm.org>
2012-07-05 19:57 ` Bart Van Assche
2012-07-10 0:29 ` Nicholas A. Bellinger
2012-07-05 2:01 ` Nicholas A. Bellinger
[not found] ` <1341453665.23954.224.camel@haakon2.linux-iscsi.org>
2012-07-05 9:31 ` Michael S. Tsirkin
2012-07-06 3:13 ` Nicholas A. Bellinger
[not found] ` <1341375846-27882-6-git-send-email-nab@linux-iscsi.org>
2012-07-04 14:50 ` [PATCH 5/6] virtio-scsi: Add vdrv->scan for post VIRTIO_CONFIG_S_DRIVER_OK LUN scanning Paolo Bonzini
[not found] ` <1341375846-27882-7-git-send-email-nab@linux-iscsi.org>
2012-07-04 14:50 ` [PATCH 6/6] virtio-scsi: Set shost->max_id=1 for tcm_vhost WWPNs Paolo Bonzini
2012-07-05 2:05 ` Nicholas A. Bellinger
2012-07-05 6:42 ` Paolo Bonzini [this message]
[not found] ` <1341375846-27882-5-git-send-email-nab@linux-iscsi.org>
2012-07-05 17:47 ` [PATCH 4/6] tcm_vhost: Initial merge for vhost level target fabric driver Bart Van Assche
[not found] ` <4FF5D31F.90404@acm.org>
2012-07-05 17:59 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF5373E.8080703@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@linux.vnet.ibm.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wuzhy@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).