From: David Hildenbrand <david@redhat.com>
To: Gavin Shan <gshan@redhat.com>, virtualization@lists.linux-foundation.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
shan.gavin@gmail.com,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] drivers/virtio: Enable virtio mem for ARM64
Date: Tue, 18 Jan 2022 09:38:21 +0100 [thread overview]
Message-ID: <4fe8127e-6e24-64bd-c53b-bf4ffa15b4b4@redhat.com> (raw)
In-Reply-To: <20220118013431.167347-1-gshan@redhat.com>
On 18.01.22 02:34, Gavin Shan wrote:
> This enables virtio-mem device support by allowing to enable the
> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
> architecture.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> drivers/virtio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 34f80b7a8a64..bf3f6ebdaa3b 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON
> config VIRTIO_MEM
> tristate "Virtio mem driver"
> default m
> - depends on X86_64
> + depends on X86_64 || ARM64
> depends on VIRTIO
> depends on MEMORY_HOTPLUG
> depends on MEMORY_HOTREMOVE
With MEMBLOCK_DRIVER_MANAGED in place upstream, kexec should be fine.
Can you adjust/rephrase the comment as well? Like
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 34f80b7a8a64..88028ca01c8f 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -116,8 +116,9 @@ config VIRTIO_MEM
This driver provides access to virtio-mem paravirtualized memory
devices, allowing to hotplug and hotunplug memory.
- This driver was only tested under x86-64, but should theoretically
- work on all architectures that support memory hotplug and hotremove.
+ This driver was only tested under x86-64 and arm64, but should
+ theoretically work on all architectures that support memory hotplug and
+ hotremove.
If unsure, say M.
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-01-18 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 1:34 [PATCH] drivers/virtio: Enable virtio mem for ARM64 Gavin Shan
2022-01-18 8:38 ` David Hildenbrand [this message]
2022-01-18 8:42 ` Gavin Shan
[not found] ` <20220118092249.0000358c@Huawei.com>
2022-01-18 9:33 ` Gavin Shan
2022-01-18 10:43 ` Michael S. Tsirkin
2022-01-18 10:48 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe8127e-6e24-64bd-c53b-bf4ffa15b4b4@redhat.com \
--to=david@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=gshan@redhat.com \
--cc=mst@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).